Skip to content

Minor improvements to SharePoint Embedded auth page#10847

Merged
andrewconnell merged 5 commits into
SharePoint:mainfrom
dluces:user/dluces/spe_auth_confidential_client_notes
May 22, 2026
Merged

Minor improvements to SharePoint Embedded auth page#10847
andrewconnell merged 5 commits into
SharePoint:mainfrom
dluces:user/dluces/spe_auth_confidential_client_notes

Conversation

@dluces
Copy link
Copy Markdown
Contributor

@dluces dluces commented May 20, 2026

Category

  • Content fix
  • New article

Related issues

  • fixes n/a
  • partially n/a
  • mentioned in n/a

What's in this Pull Request?

Three different changes:

  • Fix overview line to clarify access in user-delegated mode to not be constrained to container membership (specific driveItem access can be granted)
  • Recommend that confidential client applications are used in order to retain control.
  • Remove recommendation to delete FSCTR.Selected from manifest once a container type is registered in a consuming tenant. This was incorrect. Apps need the scope to maintain control over container type registrations.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

learn-build-service-prod Bot commented May 20, 2026

Learn Build status updates of commit 4df8204:

✅ Validation status: passed

File Status Preview URL Details
docs/embedded/development/auth.md ✅Succeeded View

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

learn-build-service-prod Bot commented May 20, 2026

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@andrewconnell andrewconnell self-assigned this May 21, 2026
@andrewconnell andrewconnell added the pr:in-review Actively reviewing pull request label May 21, 2026
@andrewconnell andrewconnell self-requested a review May 21, 2026 09:38
@andrewconnell
docs(spe): update auth article
517e86b 
- address acrolinx findings
- revert `ms.date` to original publication date; rendering engine
  shows last modified date dynamically from git history
andrewconnell
andrewconnell approved these changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@andrewconnell andrewconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding minor updates

@andrewconnell andrewconnell added pr:ready-to-merge Ready to merge PR and removed pr:in-review Actively reviewing pull request labels May 21, 2026
@learn-build-service-prod
Copy link
Copy Markdown
Contributor

learn-build-service-prod Bot commented May 21, 2026

Learn Build status updates of commit 517e86b:

✅ Validation status: passed

File Status Preview URL Details
docs/embedded/development/auth.md ✅Succeeded View

For more details, please refer to the build report.

@andrewconnell andrewconnell added pr:in-review Actively reviewing pull request and removed pr:ready-to-merge Ready to merge PR labels May 21, 2026
@learn-build-service-prod
Copy link
Copy Markdown
Contributor

learn-build-service-prod Bot commented May 21, 2026

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@andrewconnell andrewconnell added the pr:awaiting-peer-reviews Awaiting the requested reviewers to complete their review. label May 21, 2026
@andrewconnell
Copy link
Copy Markdown
Collaborator

andrewconnell commented May 21, 2026

@dluces LGTM... waiting on other requested reviewers to complete their reviews before merging.

*In the past, we were reviewing & merging all open PR's regardless if all reviewers had completed their review. However, going forward, we'll wait for all reviews to be approved before merging the PR.

@cindylay cindylay removed the request for review from marcwindle May 21, 2026 19:08
@cindylay
Copy link
Copy Markdown
Contributor

cindylay commented May 21, 2026

Good to merge

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

learn-build-service-prod Bot commented May 21, 2026

Learn Build status updates of commit 43e00ed:

✅ Validation status: passed

File Status Preview URL Details
docs/embedded/development/auth.md ✅Succeeded View

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

learn-build-service-prod Bot commented May 21, 2026

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@dluces
Copy link
Copy Markdown
Contributor Author

dluces commented May 21, 2026

Thanks @andrewconnell and @cindylay. Everyone has approved now. Good to merge this anytime.

@andrewconnell andrewconnell added pr:ready-to-merge Ready to merge PR and removed pr:awaiting-peer-reviews Awaiting the requested reviewers to complete their review. pr:in-review Actively reviewing pull request labels May 22, 2026
@andrewconnell andrewconnell merged commit 34c2be0 into SharePoint:main May 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewconnell andrewconnell andrewconnell approved these changes

@gnjoseph gnjoseph gnjoseph approved these changes

@cindylay cindylay cindylay approved these changes

@tonchan-msft tonchan-msft tonchan-msft approved these changes

Assignees

@andrewconnell andrewconnell

Labels

pr:ready-to-merge Ready to merge PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dluces @andrewconnell @cindylay @gnjoseph @tonchan-msft