making get_brawlers (issue #60) by 0dminnimda · Pull Request #61 · SharpBit/brawlstats

0dminnimda · 2020-06-27T05:32:16Z

Changes Description

all py files were refactored in pep8 style
(except for 97 lines in utils.py)
splitting BaseBox into BaseBox and BaseBoxList for convenience
(with the corresponding estates of both the models themselves and the models inheriting these models)
added:

get_brawlers function
model Brawlers
BRAWLERS_URL in API
nothing function to replace lambda expressions in typecasted

changed async.py and sync.py (now they are completely identical, in terms of meaning)
adding tests to files from tests /
tox for py38 now works
adding documentation to CHANGELOG.md, api.rst, index.rst
7.5) add some.py to gitignore

Checklist

[yes] Docstrings added (NumpyDoc)
[added] If necessary, add to the documentation files
[yes] Tox checked

major changes: 1) all py files were refactored in pep8 style 2) splitting BaseBox into BaseBox and BaseBoxList for convenience (with the corresponding estates of both the models themselves and the models inheriting these models) 3) added: - get_brawlers function - model Brawlers - BRAWLERS_URL in API - nothing function to replace lambda expressions in typecasted 4) changed async.py and sync.py (now they are completely identical, in terms of meaning)

This reverts commit 17e7066.

major changes: 1) all py files were refactored in pep8 style (except for 97 lines in utils.py) 2) splitting BaseBox into BaseBox and BaseBoxList for convenience (with the corresponding estates of both the models themselves and the models inheriting these models) 3) added: - get_brawlers function - model Brawlers - BRAWLERS_URL in API - nothing function to replace lambda expressions in typecasted 4) changed async.py and sync.py (now they are completely identical, in terms of meaning) .. add some of my files to gitignore

SharpBit · 2020-06-27T13:22:18Z

Please revert everything and readd only the tests for get_brawler, the models/functions for get_brawler and the fix for tox for 3.8

Please don't mess with code formatting, I purposely have the character limit as 120 chars since pep8's 80 character limit per line is just plain stupid and inconvenient
You've added random f strings on docstrings where they're not needed and left in some Python-3.5-incompatible code (some fstrings). Again, please revert and only add the code needed for get_brawler and the changes to tox that lets you run it for Python 3.8

0dminnimda · 2020-06-27T14:04:58Z

I corrected everything, but you should know that pep8 standards did not come from the air!

fourjr

some of my feedback regarding code clarity

fourjr · 2020-06-27T14:01:15Z

@@ -1,3 +1,5 @@
+some.py


extra files should not be added to the .gitignore

nothing bad here, I just need to ignore some files. it does not spoil, you can remove this change

If you need another file, move it into another directory - do not add unnecessary stuff to the project's .gitignore file

fourjr · 2020-06-27T14:01:46Z

+### Changed
+- splitting `BaseBox` into `BaseBox` and `BaseBoxList` for convenience
+### Fixed
+- tox for py38 works (not completely sure)


tox should be tested first...

I do not often create tox files (so I'm not sure), but it works fine for me

here too that to the bottom post

fourjr · 2020-06-27T14:03:24Z

+
+# do nothing
+def nothing(value):
+    return value


i dont think its necessary to create a function here, the lambda works just fine and is cleaner

fourjr · 2020-06-27T14:03:46Z

            converter = param.annotation
            if converter is inspect._empty:
-                converter = lambda a: a  # do nothing
+                converter = nothing


i dont think its necessary to create a function here, the lambda works just fine and is cleaner

lambda expression is created every time, and the function is defined, I think that it is worth avoiding lambda expressions, there is no problem to remove it here

lambda expression can result in unexpected performance issues

so I would recommend you leave this part alone

SharpBit · 2020-06-27T18:26:15Z

Transferred to PR #62

0dminnimda added 5 commits June 27, 2020 05:33

Revert "many interesting things (see description)"

84a235d

This reverts commit 17e7066.

test creation, redo tox for py38

c87181f

documentation creation

ba8eded

0dminnimda changed the title ~~making get brawlers (issue #60)~~ making get_brawlers (issue #60) Jun 27, 2020

0dminnimda added 3 commits June 27, 2020 09:04

this is solving (issue #60) also resolving compatibility issues

ad440d6

Update utils.py

d6b8fb9

little change

7dcc3e5

0dminnimda added 2 commits June 27, 2020 16:58

revert some of the code, as requested by sharpBit

d2bc532

little change

4897138

fourjr reviewed Jun 27, 2020

View reviewed changes

edit gitignore

3f863ce

SharpBit closed this Jun 27, 2020

0dminnimda deleted the issue_60_making_get_brawlers branch July 22, 2020 14:56

Conversation

0dminnimda commented Jun 27, 2020

Changes Description

Checklist

Uh oh!

SharpBit commented Jun 27, 2020

Uh oh!

0dminnimda commented Jun 27, 2020

Uh oh!

fourjr left a comment

Choose a reason for hiding this comment

Uh oh!

fourjr Jun 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0dminnimda Jun 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SharpBit commented Jun 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fourjr Jun 27, 2020 •

edited

Loading

0dminnimda Jun 27, 2020 •

edited

Loading