Issue 60 making get brawlers#62
Merged
SharpBit merged 14 commits intoJun 27, 2020
Merged
Conversation
Fix brawlers for python 3.5, fix tests
major changes: 1) all py files were refactored in pep8 style 2) splitting BaseBox into BaseBox and BaseBoxList for convenience (with the corresponding estates of both the models themselves and the models inheriting these models) 3) added: - get_brawlers function - model Brawlers - BRAWLERS_URL in API - nothing function to replace lambda expressions in typecasted 4) changed async.py and sync.py (now they are completely identical, in terms of meaning)
This reverts commit 17e7066.
major changes: 1) all py files were refactored in pep8 style (except for 97 lines in utils.py) 2) splitting BaseBox into BaseBox and BaseBoxList for convenience (with the corresponding estates of both the models themselves and the models inheriting these models) 3) added: - get_brawlers function - model Brawlers - BRAWLERS_URL in API - nothing function to replace lambda expressions in typecasted 4) changed async.py and sync.py (now they are completely identical, in terms of meaning) .. add some of my files to gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Description
(with the corresponding estates of both the models themselves and the models inheriting these models)
Checklist