feat(output): publish EventHeader from every generator source - #94
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe change raises the ChangesEvent header support
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to This localized change has no actionable merge-blocking risk in the supplied evidence and is merge-ready after normal checks and review. Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant ParticleSource
participant EventHeaderProduct
participant MCOutputWriter
participant SimOutputWriter
ParticleSource->>EventHeaderProduct: publish SHiP::EventHeader
EventHeaderProduct->>MCOutputWriter: provide event_header with mc_particles
MCOutputWriter->>MCOutputWriter: bind header and write RNTuple entry
EventHeaderProduct->>SimOutputWriter: provide event_header with mc_particles and sim_results
SimOutputWriter->>SimOutputWriter: filter empty hits, bind header, and write entry
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ prek hooks passed |
Physics Metrics ComparisonAll configurations match reference (no significant differences)
About this comparisonPhysics metrics are extracted from ROOT files and compared. Metrics stored in git notes: |
olantwin
left a comment
There was a problem hiding this comment.
Please make prek happy. Apart from that, this looks good for merging.
|
Some other generators will probably need updating, e.g. genie and the file sources. I'll do those in a follow-up PR. |
87ba937 to
615cc0a
Compare
Checklist
pixi run lint)Stack created with GitHub Stacks CLI • Give Feedback 💬
Summary by CodeRabbit
New Features
Bug Fixes
Documentation