Skip to content

[Refactor] Clean up dead code and improve type safety in TomlFile #8277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 2 commits into from
Aug 10, 2026
+5 −5
Merged

[Refactor] Clean up dead code and improve type safety in TomlFile #8277

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85b5c5b
[Refactor] Clean up dead code and improve type safety in TomlFile
gonzaloriestra Aug 10, 2026
80c5de5
[Refactor] Clean up code and improve type safety in TomlFile without …
gonzaloriestra Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/cli-kit/src/public/node/toml/toml-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,11 @@ export class TomlFile {
private decode(raw: string): JsonMapType {
try {
return decodeToml(raw)
// eslint-disable-next-line @typescript-eslint/no-explicit-any
} catch (err: any) {
if (err.line !== undefined && err.col !== undefined) {
const description = String(err.message).split('\n')[0] ?? 'Invalid TOML'
throw new TomlFileError(this.path, `${description} at row ${err.line}, col ${err.col}`)
} catch (err) {
const tomlError = err as {line?: number; col?: number; message?: string}
if (tomlError.line !== undefined && tomlError.col !== undefined) {
const description = String(tomlError.message).split('\n')[0] ?? 'Invalid TOML'
throw new TomlFileError(this.path, `${description} at row ${tomlError.line}, col ${tomlError.col}`)
}
throw err
}
Expand Down
Loading