Fix under rails 4.0.4+#138
Merged
Merged
Conversation
Also add timestamps to a few testing models
Contributor
Author
There was a problem hiding this comment.
we need to add timestamps to some models, otherwise .touch will fail
Contributor
There was a problem hiding this comment.
Are these additional timestamps why test/fixtures/serialized_record changed?
Contributor
Author
There was a problem hiding this comment.
because now those fields need to be serialized on the fixture.
Contributor
Author
|
Can I merge this and release a new |
Contributor
|
👍 On Tuesday, March 25, 2014, Arthur Nogueira Neves notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes tests on rails 4.0.4.
Problem
PR rails/rails#12031 was merged into rails 4.0.4, which means that the
touchmethod will now callafter_commitcallbacks.Solution.
Dont use the
after_touchcallback anymore.review @dylanahsmith @camilo
cc @jnormore @airhorns