[IndexFilters] Allow cancel button to be removed and auto-focus on Search field to be removed #11604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/snapit |
1 similar comment
Contributor
Author
|
/snapit |
Contributor
|
✨ Thanks @mrcthms! Your snapshot has been published to npm. Test the snapshot by updating your npm install @shopify/polaris@0.0.0-snapshot-20240219101217 |
mrcthms
force-pushed
the
mrcthms-index-filters-allow-remove-cancel-and-no-focus
branch
from
fb4c8fc to
f0a847f
Compare
Contributor
Author
|
/snapit |
Contributor
|
✨ Thanks @mrcthms! Your snapshot has been published to npm. Test the snapshot by updating your npm install @shopify/polaris@0.0.0-snapshot-20240219105953 |
mrcthms
force-pushed
the
mrcthms-index-filters-allow-remove-cancel-and-no-focus
branch
from
f0a847f to
883ed09
Compare
Contributor
Author
|
/snapit |
Contributor
|
✨ Thanks @mrcthms! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-icons@0.0.0-snapshot-20240221122800yarn add @shopify/polaris@0.0.0-snapshot-20240221122800 |
ouellettejordan
approved these changes
Feb 21, 2024
ouellettejordan
left a comment
ouellettejordan
left a comment
There was a problem hiding this comment.
Tested and looks good. Important improvement.
mrcthms
deleted the
mrcthms-index-filters-allow-remove-cancel-and-no-focus
branch
Merged
lgriffee
pushed a commit
that referenced
this pull request
Feb 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@8.5.0 ### Minor Changes - [#11639](#11639) [`4db32af27`](4db32af) Thanks [@ardakaracizmeli](https://github.com/ardakaracizmeli)! - Added a new icon: ArrowDiagonal ### Patch Changes - [#11633](#11633) [`8a9225306`](8a92253) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update mobile icon design ## @shopify/polaris@12.18.0 ### Minor Changes - [#11625](#11625) [`9aed8c18f`](9aed8c1) Thanks [@sainihas](https://github.com/sainihas)! - Fix truncate issue for text in ContextualSaveBar - [#11604](#11604) [`376e6ded7`](376e6de) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated IndexFilters to better support a configuration of only search and sort - [#11613](#11613) [`92d02613b`](92d0261) Thanks [@lgriffee](https://github.com/lgriffee)! - Deprecated `heading2xl` and `heading3xl` variants in `Text` component - [#11611](#11611) [`b79741cf8`](b79741c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added `size` prop to `Tag` ### Patch Changes - [#11624](#11624) [`b60ba0710`](b60ba07) Thanks [@lgriffee](https://github.com/lgriffee)! - Reverted application of native mobile styles to Button component - [#11628](#11628) [`bef27c076`](bef27c0) Thanks [@ardakaracizmeli](https://github.com/ardakaracizmeli)! - Fixed an issue where a border displayed between the main content of the frame and the sidebar - Updated dependencies \[[`4db32af27`](4db32af), [`8a9225306`](8a92253)]: - @shopify/polaris-icons@8.5.0 ## polaris.shopify.com@0.63.1 ### Patch Changes - Updated dependencies \[[`b60ba0710`](b60ba07), [`4db32af27`](4db32af), [`9aed8c18f`](9aed8c1), [`376e6ded7`](376e6de), [`8a9225306`](8a92253), [`92d02613b`](92d0261), [`b79741cf8`](b79741c), [`bef27c076`](bef27c0)]: - @shopify/polaris@12.18.0 - @shopify/polaris-icons@8.5.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
|
Thank you! 🙌 |
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…arch field to be removed (Shopify#11604) ### WHY are these changes introduced? Addresses Shopify/web#119079 A lot of SettingsTable instances in the settings area of the admin only need search and sort functionality, and currently you have to either toggle into the search experience, or get an auto-focused search on initial render, as well as a non-functioning Cancel button, using the IndexFilters component. This PR updates the IndexFilters component to allow for a search/sort only configuration. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) Spinstance: https://admin.web.settings-table-2.marc-thomas.eu.spin.dev/store/shop1/settings/taxes Storybook: https://5d559397bae39100201eedc1-pidlxuuieh.chromatic.com/?path=/story/all-components-indexfilters--with-only-search-and-sort ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Addresses https://github.com/Shopify/web/issues/119079
A lot of SettingsTable instances in the settings area of the admin only need search and sort functionality, and currently you have to either toggle into the search experience, or get an auto-focused search on initial render, as well as a non-functioning Cancel button, using the IndexFilters component.
This PR updates the IndexFilters component to allow for a search/sort only configuration.
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Spinstance: https://admin.web.settings-table-2.marc-thomas.eu.spin.dev/store/shop1/settings/taxes
Storybook: https://5d559397bae39100201eedc1-pidlxuuieh.chromatic.com/?path=/story/all-components-indexfilters--with-only-search-and-sort
🎩 checklist
README.mdwith documentation changes