Skip to content

Conversation

@ardakaracizmeli
Copy link
Contributor

@ardakaracizmeli ardakaracizmeli commented Feb 22, 2024

WHY are these changes introduced?

Fixes #11638

WHAT is this pull request doing?

Adding the new ArrowDiagonal icon

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@ardakaracizmeli ardakaracizmeli requested review from chloerice, heyjoethomas and kyledurand and removed request for chloerice February 22, 2024 16:49
@ardakaracizmeli ardakaracizmeli merged commit 4db32af into main Feb 22, 2024
@ardakaracizmeli ardakaracizmeli deleted the add-arrow-diagonal-icon branch February 22, 2024 17:17
lgriffee pushed a commit that referenced this pull request Feb 22, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@8.5.0

### Minor Changes

- [#11639](#11639)
[`4db32af27`](4db32af)
Thanks [@ardakaracizmeli](https://github.com/ardakaracizmeli)! - Added a
new icon: ArrowDiagonal

### Patch Changes

- [#11633](#11633)
[`8a9225306`](8a92253)
Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update mobile
icon design

## @shopify/polaris@12.18.0

### Minor Changes

- [#11625](#11625)
[`9aed8c18f`](9aed8c1)
Thanks [@sainihas](https://github.com/sainihas)! - Fix truncate issue
for text in ContextualSaveBar


- [#11604](#11604)
[`376e6ded7`](376e6de)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated IndexFilters to
better support a configuration of only search and sort


- [#11613](#11613)
[`92d02613b`](92d0261)
Thanks [@lgriffee](https://github.com/lgriffee)! - Deprecated
`heading2xl` and `heading3xl` variants in `Text` component


- [#11611](#11611)
[`b79741cf8`](b79741c)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added `size` prop
to `Tag`

### Patch Changes

- [#11624](#11624)
[`b60ba0710`](b60ba07)
Thanks [@lgriffee](https://github.com/lgriffee)! - Reverted application
of native mobile styles to Button component


- [#11628](#11628)
[`bef27c076`](bef27c0)
Thanks [@ardakaracizmeli](https://github.com/ardakaracizmeli)! - Fixed
an issue where a border displayed between the main content of the frame
and the sidebar

- Updated dependencies
\[[`4db32af27`](4db32af),
[`8a9225306`](8a92253)]:
    -   @shopify/polaris-icons@8.5.0

## polaris.shopify.com@0.63.1

### Patch Changes

- Updated dependencies
\[[`b60ba0710`](b60ba07),
[`4db32af27`](4db32af),
[`9aed8c18f`](9aed8c1),
[`376e6ded7`](376e6de),
[`8a9225306`](8a92253),
[`92d02613b`](92d0261),
[`b79741cf8`](b79741c),
[`bef27c076`](bef27c0)]:
    -   @shopify/polaris@12.18.0
    -   @shopify/polaris-icons@8.5.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Open it as a draft if it’s a work in progress
-->

### WHY are these changes introduced?

Fixes Shopify#11638 

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Adding the new ArrowDiagonal icon

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

  Include a video if your changes include interactive content.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

  <details>
    <summary>Summary of your gif(s)</summary>
    <img src="..." alt="Description of what the gif shows">
  </details>
-->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [x] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [x] Updated the component's `README.md` with documentation changes
- [x] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: kyledurand <kyle.durand@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Icon]: New icon ArrowDiagonal

2 participants