[Tag] Add large size with discrete remove button #11611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyledurand
force-pushed
the
tag-add-large-size
branch
from
98d6741 to
d5f9261
Compare
kyledurand
force-pushed
the
tag-add-large-size
branch
from
d5f9261 to
63c9fc4
Compare
kyledurand
force-pushed
the
tag-add-large-size
branch
from
63c9fc4 to
77d3f94
Compare
laurkim
approved these changes
Feb 21, 2024
Contributor
laurkim
left a comment
laurkim
left a comment
There was a problem hiding this comment.
💯
Small suggestion (not blocking) but might be worth adding the new stories to the style guide for consistency
tjonx
approved these changes
Feb 21, 2024
Merged
lgriffee
pushed a commit
that referenced
this pull request
Feb 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@8.5.0 ### Minor Changes - [#11639](#11639) [`4db32af27`](4db32af) Thanks [@ardakaracizmeli](https://github.com/ardakaracizmeli)! - Added a new icon: ArrowDiagonal ### Patch Changes - [#11633](#11633) [`8a9225306`](8a92253) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update mobile icon design ## @shopify/polaris@12.18.0 ### Minor Changes - [#11625](#11625) [`9aed8c18f`](9aed8c1) Thanks [@sainihas](https://github.com/sainihas)! - Fix truncate issue for text in ContextualSaveBar - [#11604](#11604) [`376e6ded7`](376e6de) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated IndexFilters to better support a configuration of only search and sort - [#11613](#11613) [`92d02613b`](92d0261) Thanks [@lgriffee](https://github.com/lgriffee)! - Deprecated `heading2xl` and `heading3xl` variants in `Text` component - [#11611](#11611) [`b79741cf8`](b79741c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added `size` prop to `Tag` ### Patch Changes - [#11624](#11624) [`b60ba0710`](b60ba07) Thanks [@lgriffee](https://github.com/lgriffee)! - Reverted application of native mobile styles to Button component - [#11628](#11628) [`bef27c076`](bef27c0) Thanks [@ardakaracizmeli](https://github.com/ardakaracizmeli)! - Fixed an issue where a border displayed between the main content of the frame and the sidebar - Updated dependencies \[[`4db32af27`](4db32af), [`8a9225306`](8a92253)]: - @shopify/polaris-icons@8.5.0 ## polaris.shopify.com@0.63.1 ### Patch Changes - Updated dependencies \[[`b60ba0710`](b60ba07), [`4db32af27`](4db32af), [`9aed8c18f`](9aed8c1), [`376e6ded7`](376e6de), [`8a9225306`](8a92253), [`92d02613b`](92d0261), [`b79741cf8`](b79741c), [`bef27c076`](bef27c0)]: - @shopify/polaris@12.18.0 - @shopify/polaris-icons@8.5.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Open it as a draft if it’s a work in progress --> ### WHY are these changes introduced? Fixes https://github.com/Shopify/polaris-internal/issues/1441 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? https://github.com/Shopify/polaris/assets/6844391/3b8fb8f8-681c-4505-bbcc-85eb47d69f1f <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. Include a video if your changes include interactive content. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris-internal/issues/1441
WHAT is this pull request doing?
Screen.Recording.2024-02-16.at.09.13.29.mov
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes