Skip to content

Conversation

@lgriffee
Copy link
Contributor

@lgriffee lgriffee commented Feb 16, 2024

WHY are these changes introduced?

Fixes https://github.com/Shopify/polaris-internal/issues/1378

WHAT is this pull request doing?

  • Adds new functionality to console.warn() for deprecated prop values
    Screenshot 2024-02-21 at 10 23 19 AM
  • Updates deprecation guide info

@lgriffee lgriffee self-assigned this Feb 21, 2024
@lgriffee lgriffee added the #gsd:38846 Admin Quality Improvements (Q1 2024) label Feb 21, 2024
@lgriffee lgriffee marked this pull request as ready for review February 21, 2024 17:19
@aaronccasanova
Copy link
Member

/snapit

lgriffee and others added 3 commits February 21, 2024 13:51
Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
@aaronccasanova
Copy link
Member

/snapit

@github-actions
Copy link
Contributor

Thanks @aaronccasanova! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-icons@0.0.0-snapshot-20240221211134
yarn add @shopify/polaris@0.0.0-snapshot-20240221211134

@lgriffee lgriffee merged commit 92d0261 into main Feb 21, 2024
@lgriffee lgriffee deleted the text-heading-deprecation-warnings branch February 21, 2024 21:14
lgriffee pushed a commit that referenced this pull request Feb 22, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@8.5.0

### Minor Changes

- [#11639](#11639)
[`4db32af27`](4db32af)
Thanks [@ardakaracizmeli](https://github.com/ardakaracizmeli)! - Added a
new icon: ArrowDiagonal

### Patch Changes

- [#11633](#11633)
[`8a9225306`](8a92253)
Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Update mobile
icon design

## @shopify/polaris@12.18.0

### Minor Changes

- [#11625](#11625)
[`9aed8c18f`](9aed8c1)
Thanks [@sainihas](https://github.com/sainihas)! - Fix truncate issue
for text in ContextualSaveBar


- [#11604](#11604)
[`376e6ded7`](376e6de)
Thanks [@mrcthms](https://github.com/mrcthms)! - Updated IndexFilters to
better support a configuration of only search and sort


- [#11613](#11613)
[`92d02613b`](92d0261)
Thanks [@lgriffee](https://github.com/lgriffee)! - Deprecated
`heading2xl` and `heading3xl` variants in `Text` component


- [#11611](#11611)
[`b79741cf8`](b79741c)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added `size` prop
to `Tag`

### Patch Changes

- [#11624](#11624)
[`b60ba0710`](b60ba07)
Thanks [@lgriffee](https://github.com/lgriffee)! - Reverted application
of native mobile styles to Button component


- [#11628](#11628)
[`bef27c076`](bef27c0)
Thanks [@ardakaracizmeli](https://github.com/ardakaracizmeli)! - Fixed
an issue where a border displayed between the main content of the frame
and the sidebar

- Updated dependencies
\[[`4db32af27`](4db32af),
[`8a9225306`](8a92253)]:
    -   @shopify/polaris-icons@8.5.0

## polaris.shopify.com@0.63.1

### Patch Changes

- Updated dependencies
\[[`b60ba0710`](b60ba07),
[`4db32af27`](4db32af),
[`9aed8c18f`](9aed8c1),
[`376e6ded7`](376e6de),
[`8a9225306`](8a92253),
[`92d02613b`](92d0261),
[`b79741cf8`](b79741c),
[`bef27c076`](bef27c0)]:
    -   @shopify/polaris@12.18.0
    -   @shopify/polaris-icons@8.5.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
### WHY are these changes introduced?

Fixes https://github.com/Shopify/polaris-internal/issues/1378

### WHAT is this pull request doing?
-  Adds new functionality to console.warn() for deprecated prop values
![Screenshot 2024-02-21 at 10 23
19 AM](https://github.com/Shopify/polaris/assets/21976492/e05216ec-ba1b-4221-b50f-a2a039b97d3b)
-  Updates deprecation guide info

---------

Co-authored-by: aveline <aveline@users.noreply.github.com>
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:38846 Admin Quality Improvements (Q1 2024)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants