fix(🍎): fix memory leaks from unregistered view updates and mapper closures - #3932
Merged
wcandillon merged 2 commits intoJul 10, 2026
Merged
Conversation
…stry On iOS (and Android), every image drawn in a Canvas — most visibly makeImageFromView snapshots at ~W*H*4 bytes each — could stay resident after dispose(), GC, and unmount: 1. NativeReanimatedContainer never stopped its Reanimated mapper on unmount; stopMapper only ran at the start of the next redraw, which never comes for an unmounted Canvas. The leaked mapper closure permanently retained the recorder (whose commands hold sk_sp<SkImage> copies of every drawn image) and the SkPicture, so the CFData pixel copy made in ViewScreenshotService was never released. Stop the mapper in unmount() (native and web containers). 2. The leaked mapper (or the queued first-frame runOnUI) kept calling setJsiProperty(nativeId, "picture", ...) after the native view had unregistered, and ViewRegistry::withViewInfo recreated the erased entry, storing the sk_sp<SkPicture> in the process-global registry under a nativeId that is never reused — a permanent leak. Tombstone unregistered ids so late property updates get a transient info object instead of resurrecting the entry (registration paths revive the id, which also keeps ids valid across JS reloads). 3. requestRedraw/makeImageSnapshot(Async)/size created empty registry entries for unknown ids; they now use a read-only lookup. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012PsKgiwBDKyJyBcRCGCeQj
Contributor
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.