chore(🎨): add tests for Color constructor - #3945
Merged
Merged
Conversation
…er colors The native conversion of plain number arrays in Skia.Color() was fixed in af4070b (#3719): JsiSkColor.h createCtor now converts a 4-element JS array into a Float32Array, and JsiSkColor::fromValue as well as the recorder Convertor.h accept plain arrays. The web implementation already converted arrays via new Float32Array(color). These tests lock in the behavior reported in the issue: Skia.Color([r,g,b,a]) (0-1 floats) round-trips identically to Skia.Color(new Float32Array([...])) and to the equivalent string and ARGB number colors, on both web and native. Fixes #2200 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.