fix(🤖): fail gracefully if the OpenGL context can't be created#3950
Merged
Conversation
…reated On Android 10 devices with PowerVR GE8320 GPUs (Redmi 9C/9A, Oppo A15, Realme C11, ...), EGL context/surface creation can fail and the null result was dereferenced in gl::Context::makeCurrent and OpenGLWindowContext, crash-looping the app with SIGSEGV on the first <Canvas> render. Check every EGL creation result, log the error, and skip rendering instead of crashing. Fixes #3793 Relates to #3156 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3793
Relates to #3156