fix(🐛): rename leftover rnwgpu namespace to RNJsi to fix ODR clash - #3991
Merged
Conversation
…th react-native-webgpu The typed-JSI-bindings migration copied the NativeObject/JSIConverter files from react-native-webgpu but left eight files in the rnwgpu namespace. When both libraries are linked into one app, the template instantiations (e.g. rnwgpu::StaticRuntimeAwareCache<rnwgpu:: PrototypeCacheEntry>::get) have identical mangled names in both packages with different bodies. The linker keeps a single weak definition, so webgpu's prototype installation can execute Skia's copy, which reads RNJsi::BaseRuntimeAwareCache::_mainRuntime before RNSkManager has set it and aborts: Assertion failed: (rt != nullptr && "Expected main Javascript runtime to be set in the BaseRuntimeAwareCache class."), RuntimeAwareCache.h line 27 Moving the copied files into RNJsi gives every colliding symbol a distinct mangled name. Verified against react-native-webgpu@0.8.1: the assert reproduced before the rename and the app boots cleanly after, with both packages' cache instantiations present in the binary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.10.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 2.11.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typed-JSI-bindings migration copied the NativeObject/JSIConverter files from react-native-webgpu but left eight files in the rnwgpu namespace. When both libraries are linked into one app, the template instantiations (e.g. rnwgpu::StaticRuntimeAwareCache<rnwgpu:: PrototypeCacheEntry>::get) have identical mangled names in both packages with different bodies. The linker keeps a single weak definition, so webgpu's prototype installation can execute Skia's copy, which reads RNJsi::BaseRuntimeAwareCache::_mainRuntime before RNSkManager has set it and aborts:
Assertion failed: (rt != nullptr && "Expected main Javascript
runtime to be set in the BaseRuntimeAwareCache class."),
RuntimeAwareCache.h line 27
Moving the copied files into RNJsi gives every colliding symbol a distinct mangled name. Verified against react-native-webgpu@0.8.1: the assert reproduced before the rename and the app boots cleanly after, with both packages' cache instantiations present in the binary.
fixes wcandillon/react-native-webgpu#367