This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Conversation
paulomarg
force-pushed
the
add_scope_value_object
branch
2 times, most recently
from
411a9ef to
6e89875
Compare
paulomarg
force-pushed
the
add_scope_value_object
branch
from
6e89875 to
81895e4
Compare
paulomarg
changed the title
thecodepixi
reviewed
Feb 17, 2021
| expect(scopes.toString()).toEqual('read_products,read_orders,unauthenticated_write_customers'); | ||
| }); | ||
|
|
||
| it('trims implied scopes', () => { |
Contributor
There was a problem hiding this comment.
I'm curious about the "implied scopes" bit of this. I don't think this is something I'm familiar with. It looks like if an app has a write scope, we trim the read scope. Is this because having write access also grants read access?
Contributor
Author
There was a problem hiding this comment.
Yes, basically having write_something access also gives you read_something. We're basically omitting the implied scopes from the comparison so that we only return false if the effective permissions are actually different.
thecodepixi
approved these changes
Feb 18, 2021
Contributor
thecodepixi
left a comment
thecodepixi
left a comment
There was a problem hiding this comment.
This looks excellent! I think this takes care of the scope changes really nicely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We need to add the ability to tell whether an app's scopes have changed to the library. We've recently done that for
shopify_apiby adding a value object to hold the scopes instead of an array / string.WHAT is this pull request doing?
Creating a new
AuthScopesvalue object, which abstracts implied scopes and allows to easily compare two sets of scopes.It also changes the type of
Context.SCOPESto beAuthScopes, which enables apps to easily compare if a session has different scopes than the current ones:cc @rezaansyed and @NabeelAhsen - I basically ripped off the logic from
shopify_apihere!Next up:
koa-shopify-auth'sverifyRequestmiddleware to trigger OAuth if the current session's scopes no longer equal the app's current scopes