chore: update to OpenSTA 3.0#57
Conversation
- update Silimate/OpenSTA to version including OpenSTA 3.0's changes - update findPathEnds invocation - update jsonName to use string_views
Greptile SummaryThis PR updates the OpenSTA submodule to version 3.0 and adapts
Confidence Score: 4/5Safe to merge once the upstream OpenSTA PR #56 is merged; the code changes are minimal and correctly track the new API. Both API adaptations are mechanically straightforward. The findPathEnds call correctly passes sta_->scenes() in place of the old corner pointer and an empty StringSeq in place of the old nullptr groups pointer. The jsonName change to std::string_view is safe and correct. The only comments are style suggestions; there are no functional regressions in the changed code. No files require special attention beyond confirming the upstream OpenSTA submodule PR is merged before this one lands. Important Files Changed
Sequence DiagramsequenceDiagram
participant Silisizer
participant OpenSTA as OpenSTA 3.0 (sta_)
participant Network
loop Each optimization iteration
Silisizer->>OpenSTA: scenes()
OpenSTA-->>Silisizer: SceneSeq
Silisizer->>OpenSTA: "findPathEnds(scenes, StringSeq{}, ...)"
OpenSTA-->>Silisizer: PathEndSeq ends
alt ends is empty
Silisizer-->>Silisizer: break (done)
else violations found
loop Each PathEnd
Silisizer->>Network: instance(pin), cell(inst), libertyCell(cell)
Network-->>Silisizer: "LibertyCell* libcell"
end
Silisizer->>OpenSTA: replaceCell(offender, to_cell)
end
end
Silisizer->>Network: "pathName(inst), lc->name()"
Network-->>Silisizer: string_view
Silisizer->>Silisizer: jsonName(string_view) → stripped string
Reviews (1): Last reviewed commit: "chore: update to OpenSTA 3.0" | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Refactor jsonName function to use range-based for loop.
Depends on merge of Silimate/OpenSTA#56