Skip to content

First pass at POST table - #252

Merged
JimBobSquarePants merged 1 commit into
SixLabors:js/text-runsfrom
Redth:main
Mar 4, 2022
Merged

First pass at POST table#252
JimBobSquarePants merged 1 commit into
SixLabors:js/text-runsfrom
Redth:main

Conversation

@Redth

@Redth Redth commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

Roughly correct and ported from another project I had this in before, but not exactly tested after porting, so may be some rough edges

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Initial work on a POST table implementation... I had this code in another project and it was working there to parse the table properly, but I haven't had a chance to actually write tests here yet or validate it's working or probably to even wire it up properly to the API in the correct places, so it may require some finesse.

Roughly correct and ported from another project I had this in before, but not exactly tested after porting, so may be some rough edges
@CLAassistant

CLAassistant commented Mar 4, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@JimBobSquarePants
JimBobSquarePants changed the base branch from main to js/text-runs March 4, 2022 03:30
@JimBobSquarePants

Copy link
Copy Markdown
Member

Thanks @Redth I'm gonna merge this directly into my working branch so I can complete it easily. 👍

@JimBobSquarePants
JimBobSquarePants merged commit f05c44e into SixLabors:js/text-runs Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants