Make fractions optional. - #260
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #260 +/- ##
===================================
Coverage 83% 83%
===================================
Files 186 186
Lines 9457 9474 +17
Branches 1486 1493 +7
===================================
+ Hits 7919 7936 +17
Misses 1193 1193
Partials 345 345
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dlemstra
reviewed
Apr 19, 2022
| this.AssignFractionalFeatures(collection, index, count); | ||
| } | ||
|
|
||
| // Add user defined features. |
Member
There was a problem hiding this comment.
Maybe make this an extra method name instead of a comment?
Member
Author
There was a problem hiding this comment.
Och it's just a for-loop. I wouldn't bother.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #259
Fractions should not be enabled by default and should be turned on only when user defined features contain.
A. Frac feature tag.
B. Numr and Dnom feature tags.
https://docs.microsoft.com/en-us/typography/opentype/spec/features_fj#tag-frac