Skip to content

Do not require strict spec adherence - #277

Merged
JimBobSquarePants merged 2 commits into
SixLabors:mainfrom
loraderon:fix/issue269
Jun 14, 2022
Merged

Do not require strict spec adherence#277
JimBobSquarePants merged 2 commits into
SixLabors:mainfrom
loraderon:fix/issue269

Conversation

@loraderon

@loraderon loraderon commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

No longer throws InvalidFontFileException for invalid subTables.

Closes #269

@CLAassistant

CLAassistant commented Jun 14, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Jun 14, 2022

Copy link
Copy Markdown

Codecov Report

Merging #277 (a97cdf9) into main (cb8a60c) will increase coverage by 0%.
The diff coverage is 5%.

@@          Coverage Diff          @@
##            main    #277   +/-   ##
=====================================
  Coverage     81%     82%           
=====================================
  Files        216     216           
  Lines      11264   11260    -4     
  Branches    1750    1750           
=====================================
+ Hits        9233    9238    +5     
+ Misses      1607    1599    -8     
+ Partials     424     423    -1     
Flag Coverage Δ
unittests 82% <5%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/AdvancedTypographic/GPos/LookupType1SubTable.cs 82% <0%> (+1%) ⬆️
...es/AdvancedTypographic/GPos/LookupType2SubTable.cs 97% <0%> (+<1%) ⬆️
...es/AdvancedTypographic/GPos/LookupType3SubTable.cs 59% <0%> (+<1%) ⬆️
...es/AdvancedTypographic/GPos/LookupType4SubTable.cs 90% <0%> (ø)
...es/AdvancedTypographic/GPos/LookupType5SubTable.cs 89% <0%> (ø)
...es/AdvancedTypographic/GPos/LookupType6SubTable.cs 74% <0%> (ø)
...es/AdvancedTypographic/GPos/LookupType7SubTable.cs 80% <0%> (+<1%) ⬆️
...es/AdvancedTypographic/GPos/LookupType8SubTable.cs 79% <0%> (ø)
...es/AdvancedTypographic/GPos/LookupType9SubTable.cs 66% <0%> (ø)
...Tables/AdvancedTypographic/GSub/LookupListTable.cs 90% <0%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb8a60c...a97cdf9. Read the comment docs.

@JimBobSquarePants JimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Thanks!

@JimBobSquarePants
JimBobSquarePants merged commit b0111d2 into SixLabors:main Jun 14, 2022
@loraderon
loraderon deleted the fix/issue269 branch June 14, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when using TextMeasure.measure on some fonts

3 participants