Adding android OS support to SystemFontCollection - #291
Merged
Conversation
Android ttf files are located in /system/fonts
Codecov Report
@@ Coverage Diff @@
## main #291 +/- ##
=====================================
- Coverage 83% 83% -1%
=====================================
Files 222 222
Lines 12266 12271 +5
Branches 1779 1780 +1
=====================================
Hits 10248 10248
- Misses 1586 1591 +5
Partials 432 432
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Unit test for the new plateform android directory
| Assert.Contains(@"/Library/Fonts/", exception.Message, StringComparison.OrdinalIgnoreCase); | ||
| Assert.Contains(exception.SearchDirectories, e => e.IndexOf("Library/Fonts", StringComparison.OrdinalIgnoreCase) != -1); | ||
| } | ||
| else if (RuntimeInformation.IsOSPlatform(OSPlatform.Create("Android"))) |
Member
There was a problem hiding this comment.
We don't have the infrastructure in place to test this but definitely good to add for the future.
JimBobSquarePants
approved these changes
Jul 26, 2022
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
Member
There was a problem hiding this comment.
Thanks for this. Looks great 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android ttf files are located in /system/fonts
Prerequisites
Description
Adding Android fonts path to support them in MAUI project