Remove ExactSpelling = true in DllImport attributes - #309
Merged
Conversation
This doesn't change anything on the macOS side but fixes crash at startup for UWP apps compiled with the .NET Native tool chain. Hat tip @MichalStrehovsky. Fixes SixLabors#306
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
=====================================
Coverage 83% 83%
=====================================
Files 224 224
Lines 12299 12299
Branches 1788 1788
=====================================
Hits 10279 10279
Misses 1600 1600
Partials 420 420
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JimBobSquarePants
approved these changes
Nov 24, 2022
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
Member
There was a problem hiding this comment.
Thanks for this. Much appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This doesn't change anything on the macOS side but fixes crash at startup for UWP apps compiled with the .NET Native tool chain.
Hat tip @MichalStrehovsky.
Fixes #306