Fix vertical metric calculations and layout. - #329
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
=====================================
Coverage 83% 83%
=====================================
Files 227 227
Lines 12838 12832 -6
Branches 1844 1842 -2
=====================================
+ Hits 10734 10738 +4
+ Misses 1663 1653 -10
Partials 441 441
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tocsoft
approved these changes
Apr 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
While working on the updates to Drawing to allow rendering of vertically rotated fonts I discovered that we were still not rendering vertical fonts correctly for all fonts nor correctly placing the decorations.
This PR fixes both the metrics calculation and the layout. Prior iterations incorrectly negatively vertically offset the Hangul font NotoSansKR-Regular.otf.