Fix for invalid ClassDefinitionTable offset handling - #360
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #360 +/- ##
=====================================
Coverage 86% 86%
=====================================
Files 238 238
Lines 15171 15182 +11
Branches 2100 2100
=====================================
+ Hits 13073 13085 +12
Misses 1613 1613
+ Partials 485 484 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This fixes an issue discovered in the Stimulsoft forums linked from #354. The font contains an invalid offset to the
ClassDefinitionTable. I've tested rendering the font and output is as expected when we returnnull.