Update vulnarable SkiaSharp version - #385
Merged
Merged
Conversation
Update vulnarable SkiaSharp version to latest. Also update BenchmarkDotNet to latest version
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
======================================
Coverage 86% 86%
======================================
Files 238 238
Lines 15184 15229 +45
Branches 2101 2108 +7
======================================
+ Hits 13088 13189 +101
+ Misses 1613 1566 -47
+ Partials 483 474 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| <ItemGroup> | ||
| <PackageReference Include="BenchmarkDotNet" /> | ||
| <PackageReference Include="SkiaSharp" /> | ||
| <PackageReference Include="BenchmarkDotNet" Version="0.13.12" /> |
Member
There was a problem hiding this comment.
You don't want the version number here. That's handled in the targets file.
Contributor
Author
There was a problem hiding this comment.
I believe it was added by Nuget, will fix it
JimBobSquarePants
approved these changes
Feb 27, 2024
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
Member
There was a problem hiding this comment.
Looks great. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Update vulnarable SkiaSharp version to the latest. Also update BenchmarkDotNet to latest version