PSM model improvements - #8
Merged
Merged
Conversation
alanalutz
marked this pull request as ready for review
August 24, 2026 23:32
alanalutz
force-pushed
the
model_improvements
branch
from
August 27, 2026 18:43
8ca7d73 to
fb367af
Compare
cjthomas730
approved these changes
Aug 28, 2026
cjthomas730
left a comment
Collaborator
There was a problem hiding this comment.
Everything looks good to me; a minor nitpick on the variables.py which would be nice to address but isn't needed for approval. Resampling and land masking look good
alanalutz
force-pushed
the
model_improvements
branch
from
August 31, 2026 19:48
c0586fd to
f820059
Compare
alanalutz
force-pushed
the
model_improvements
branch
from
August 31, 2026 19:51
f820059 to
f3965d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvements to the propensity score model:
Created, updated, or replaced Files and/or tables
notebooks/ps_model.ipynbrenamed tonotebooks/match_cells.ipynbnotebooks/match_cells.ipynb: Code updated to apply the changes described above.Notes for reviewers
This PR does not require close review, as the propensity score model is no longer used in the current TPARA methodology. This PR mostly serves to preserve the development process in the commit history.
However, there are a couple of elements here that are still in use that I would like review on:
Stack created with GitHub Stacks CLI • Give Feedback 💬