Skip to content

Conversation

@JonathanRamos
Copy link
Contributor

Thank you for contributing to 3D Slicer!

  • To add a new extension with this pull request: Please keep content of "TODO list for submitting a new extension" section and put an 'x' character in the brackets for each todo item to indicate that you have accomplished that prerequisite.

  • To update an existing extension with this pull request: Please delete all text in this template and just describe which extension is updated and optionally tell us in a sentence what has been changed. To make extension updates easier in the future (so that you don't have to submit a new pull request after each change in your extension), you may consider replacing specific git hash in your s4ext file by a branch name (for example: master or release for nightly version; (majorVersion).(minorVersion) such as 4.10 for stable Slicer version).

TODO list for submitting a new extension

[To make sure users can find your extension, understand what it is intended for and how to use it, please complete the checklist below. You do not need to complete all the item by the time you submit the pull request, but most likely the changes will only be merged if all the tasks are done. See more information about the submission process on the Slicer wiki: https://www.slicer.org/wiki/Documentation/Nightly/Developers/Tutorials/BuildTestPackageDistributeExtensions]

  • Extension has a reasonable name (not too general, not too narrow, suggests what the extension is for)
  • Repository name is Slicer+ExtensionName
  • Extension description summarizes in 1-2 sentences what the extension is usable (should be understandable for non-experts)
  • Extension URL and revision (scmurl, scmrevision) is correct, consider using a branch name (master, release, ...) instead of a specific git has to avoid re-submitting pull request whenever the extension is updated
  • Extension icon URL is correct
  • Screenshot URLs (screenshoturls) are correct, contains at least one
  • Homepage URL points to valid webpage containing the following:
    • Extension name
    • Short description: 1-2 sentences, which summarizes what the extension is usable for
    • At least one nice, informative image, that illustrates what the extension can do. It may be a screenshot.
    • Description of contained modules: at one sentence for each module
    • Tutorial: step-by-step description of at least the most typical use case, include a few screenshots, provide download links to sample input data set
    • Publication: link to publication and/or to PubMed reference (if available)
    • License: We suggest you use a permissive license that includes patent and contribution clauses. This will help protect developers and ensure the code remains freely available. We suggest you use the Slicer License or the Apache 2.0. Always mention in your README file the license you have chosen. If you choose a different license, explain why to the extension maintainers. Depending on the license we may not be able to host your work.
      Read here to learn more about licenses.

[If you have any questions or comments then please describe them here.]

build_subdirectory .

# homepage
homepage http://slicer.org/slicerWiki/index.php/Documentation/Nightly/Extensions/CleverSegmentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page doesn't exist.

Maybe use this instead? https://github.com/JonathanRamos/SlicerCleverSegmentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thank you!

@JonathanRamos
Copy link
Contributor Author

On average, how long does it take until the extension is available?

@sjh26 sjh26 merged commit 85498a1 into Slicer:master Oct 22, 2019
@sjh26
Copy link
Contributor

sjh26 commented Oct 22, 2019

Now that it is merged, it will be availalbe tomorrow, assuming no build errors. Check http://slicer.cdash.org/index.php?project=SlicerPreview tomorrow. I will also post back here with any build errors.

@sjh26 sjh26 mentioned this pull request Oct 22, 2019
14 tasks
@sjh26
Copy link
Contributor

sjh26 commented Oct 24, 2019

Looks like you have some windows build errors:

http://slicer.cdash.org/viewBuildError.php?buildid=1729542

@JonathanRamos
Copy link
Contributor Author

Looks like you have some windows build errors:

http://slicer.cdash.org/viewBuildError.php?buildid=1729542

I am not sure how to fix that, it seem there is a linkage issue with vtkImageAlgorithm

@JonathanRamos
Copy link
Contributor Author

Looks like you have some windows build errors:

http://slicer.cdash.org/viewBuildError.php?buildid=1729542

The issue is fixed and commited to the repository. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants