Engine build - #175
Merged
womendoushihaoyin merged 4 commits intoMar 6, 2026
Merged
Conversation
Bug Snapmaker#1 (High Priority): - Fix config option: filament_settings_id → filament_ids - This was preventing filament ID info from being read correctly Bug Snapmaker#2 (Medium Priority): - Add thumbnail data support to StoreParams - Initialize empty thumbnail vectors for headless mode - Add include for ThumbnailData.hpp Bug Snapmaker#3 (Medium Priority): - Add BBLProject and BBLProfile initialization - Set to nullptr for headless mode (no project context) - Add include for ProjectTask.hpp Bug Snapmaker#4 (Low Priority): - Add resources directory validation - Check if resources directory exists - Validate key subdirectories (profiles/printers) Bug Snapmaker#5 (Low Priority): - Add temp file tracking and cleanup - Cleanup temp files on all error paths - Cleanup PlateBBoxData objects on error/success 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The code incorrectly called resources_dir() with parentheses, but resources_dir is a std::string variable, not a function. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ading 3MF When loading 3MF files, obj_inst_map was populated but objects_and_instances was not, causing the cloud slicing engine to find 0 instances on each plate. The fix converts obj_inst_map to objects_and_instances during 3MF loading, matching the data structure used by the cloud slicing engine for plate filtering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixed segmentation fault during multi-plate slicing in cloud engine: - Added comment explaining why result_mutex is intentionally not copied - Added 7 missing fields to operator=: - required_nozzle_HRC - filament_vitrification_temperature - nozzle_hrc, nozzle_type - support_traditional_timelapse - backtrace_enabled - conflict_result Root cause: std::mutex cannot be copied/moved, and missing fields caused undefined behavior when results were copied between plates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Recordings/Graphs
Tests