Skip to content

feature: change version to 0.0.0, change release_id back to nightly build - #5

Merged
womendoushihaoyin merged 1 commit into
Snapmaker:mainfrom
womendoushihaoyin:changeversion
Sep 18, 2024
Merged

feature: change version to 0.0.0, change release_id back to nightly build#5
womendoushihaoyin merged 1 commit into
Snapmaker:mainfrom
womendoushihaoyin:changeversion

Conversation

@womendoushihaoyin

Copy link
Copy Markdown
Collaborator

Description

Screenshots/Recordings/Graphs

Tests

@womendoushihaoyin
womendoushihaoyin merged commit bc74c94 into Snapmaker:main Sep 18, 2024
@womendoushihaoyin
womendoushihaoyin deleted the changeversion branch September 25, 2024 10:04
womendoushihaoyin added a commit to womendoushihaoyin/OrcaSlicer that referenced this pull request Mar 4, 2026
Bug Snapmaker#1 (High Priority):
- Fix config option: filament_settings_id → filament_ids
- This was preventing filament ID info from being read correctly

Bug Snapmaker#2 (Medium Priority):
- Add thumbnail data support to StoreParams
- Initialize empty thumbnail vectors for headless mode
- Add include for ThumbnailData.hpp

Bug Snapmaker#3 (Medium Priority):
- Add BBLProject and BBLProfile initialization
- Set to nullptr for headless mode (no project context)
- Add include for ProjectTask.hpp

Bug Snapmaker#4 (Low Priority):
- Add resources directory validation
- Check if resources directory exists
- Validate key subdirectories (profiles/printers)

Bug Snapmaker#5 (Low Priority):
- Add temp file tracking and cleanup
- Cleanup temp files on all error paths
- Cleanup PlateBBoxData objects on error/success

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
womendoushihaoyin added a commit that referenced this pull request Mar 6, 2026
* fix(engine): Fix all bugs #1-5 in cloud slicing engine

Bug #1 (High Priority):
- Fix config option: filament_settings_id → filament_ids
- This was preventing filament ID info from being read correctly

Bug #2 (Medium Priority):
- Add thumbnail data support to StoreParams
- Initialize empty thumbnail vectors for headless mode
- Add include for ThumbnailData.hpp

Bug #3 (Medium Priority):
- Add BBLProject and BBLProfile initialization
- Set to nullptr for headless mode (no project context)
- Add include for ProjectTask.hpp

Bug #4 (Low Priority):
- Add resources directory validation
- Check if resources directory exists
- Validate key subdirectories (profiles/printers)

Bug #5 (Low Priority):
- Add temp file tracking and cleanup
- Cleanup temp files on all error paths
- Cleanup PlateBBoxData objects on error/success

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(engine): resources_dir is variable not function

The code incorrectly called resources_dir() with parentheses, but resources_dir
is a std::string variable, not a function.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(engine): Populate objects_and_instances from obj_inst_map when loading 3MF

When loading 3MF files, obj_inst_map was populated but objects_and_instances
was not, causing the cloud slicing engine to find 0 instances on each plate.

The fix converts obj_inst_map to objects_and_instances during 3MF loading,
matching the data structure used by the cloud slicing engine for plate filtering.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(gcode): complete GCodeProcessorResult assignment operator

Fixed segmentation fault during multi-plate slicing in cloud engine:
- Added comment explaining why result_mutex is intentionally not copied
- Added 7 missing fields to operator=:
  - required_nozzle_HRC
  - filament_vitrification_temperature
  - nozzle_hrc, nozzle_type
  - support_traditional_timelapse
  - backtrace_enabled
  - conflict_result

Root cause: std::mutex cannot be copied/moved, and missing fields
caused undefined behavior when results were copied between plates.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
LuckZAE added a commit to LuckZAE/OrcaSlicer that referenced this pull request Jul 28, 2026
Add goal §4 + change §4: trim reporting fields to doc-required + functionally-
required only. realtime login headers drop X-Client-Type/X-Client-Id (curl-
verified); batch login headers keep them (S3 dir, per Snapmaker#5). Batch NDJSON line
trimmed aggressively (keep timestamp/level/service/message + eventName/userId/
clientType; drop 12 context fields). Batch three-piece body keeps shard fields.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant