Skip to content

Surface Didit KYC warnings on step 1, including under-review - #2125

Merged
MusabShakeel576 merged 1 commit into
qafrom
claude/kyc-under-review-warnings
Jun 7, 2026
Merged

Surface Didit KYC warnings on step 1, including under-review#2125
MusabShakeel576 merged 1 commit into
qafrom
claude/kyc-under-review-warnings

Conversation

@MusabShakeel576

@MusabShakeel576 MusabShakeel576 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

For a Didit under_review user (e.g. held due to a duplicate device/IP fingerprint), step 1 of /card/activate wasn't surfacing the warning reasons — on qa it only showed a generic "being reviewed" message. This lists the attached reasons so the user knows what's being checked.

Changes (hooks/useCardSteps/kycDisplayHelpers.ts)

  • under_review step-1 description now surfaces the attached Didit warnings ("Your application is under additional review: …"), falling back to the generic "few minutes" copy when there are none. (This branch existed on master but not qa.)
  • REJECTED / INCOMPLETE / under_review branches key off the formatted result instead of the raw warnings.length, so a warning set that produces no display text no longer renders an empty - bullet.
  • Added DUPLICATED_DEVICE_FINGERPRINT (+ duplicate IP/device) to the friendly-copy map.

All attached warnings are shown — no log_type filtering — so the user gets the full picture.

Note on the missing button

The disabled "Under Review" button already renders for a Didit under_review user (getStepButtonText"Under Review", disabled). The screenshot's denied copy + no button is the Rain DENIED render, which only appears if rainApplicationStatus: "denied" reaches the client. If this under_review user still shows the denied screen on a fresh build, share the /cards/status response and I'll trace it.

ESLint passes. kycDisplayHelpers.ts is kept identical to the master-targeted branch (#2126).

https://claude.ai/code/session_01S2muieprRUo3BGSh8yKBtR

@vercel

vercel Bot commented Jun 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
solid-app Ignored Ignored Preview Jun 7, 2026 9:43am
solid-app-staging Ignored Ignored Preview Jun 7, 2026 9:43am

Request Review

@MusabShakeel576
MusabShakeel576 force-pushed the claude/kyc-under-review-warnings branch from 789c803 to d2aca7d Compare June 7, 2026 09:42
…nder review

For a Didit under_review user (e.g. held due to a duplicate device/IP), step 1
of /card/activate now lists the attached warning reasons instead of a generic
"being reviewed" message.

- The under_review step-1 description surfaces the attached warnings
  ("Your application is under additional review: ...") with a fallback to the
  generic "few minutes" copy when there are none. (qa lacked this branch.)
- REJECTED / INCOMPLETE / under_review branches key off the formatted result so
  a text-less warning set no longer renders an empty bullet list.
- Add DUPLICATED_DEVICE_FINGERPRINT (+ duplicate IP/device) to the friendly map.

https://claude.ai/code/session_01S2muieprRUo3BGSh8yKBtR
@MusabShakeel576
MusabShakeel576 force-pushed the claude/kyc-under-review-warnings branch from d2aca7d to 2df179c Compare June 7, 2026 09:43
@MusabShakeel576 MusabShakeel576 changed the title Surface only decision-affecting KYC warnings on step 1 (incl. under-review) Surface Didit KYC warnings on step 1, including under-review Jun 7, 2026
@MusabShakeel576
MusabShakeel576 merged commit 379f28c into qa Jun 7, 2026
4 of 5 checks passed
@MusabShakeel576
MusabShakeel576 deleted the claude/kyc-under-review-warnings branch June 7, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants