Skip to content

Surface Didit KYC warnings on step 1, including under-review (master) - #2126

Merged
MusabShakeel576 merged 1 commit into
masterfrom
claude/kyc-under-review-warnings-master
Jun 7, 2026
Merged

Surface Didit KYC warnings on step 1, including under-review (master)#2126
MusabShakeel576 merged 1 commit into
masterfrom
claude/kyc-under-review-warnings-master

Conversation

@MusabShakeel576

@MusabShakeel576 MusabShakeel576 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Keeps master in sync with the qa-targeted branch (#2125) for the Didit under_review warnings display on step 1 of /card/activate. master already surfaces the attached warnings under review; this is the friendly-copy + robustness portion.

Changes (hooks/useCardSteps/kycDisplayHelpers.ts)

  • Added DUPLICATED_DEVICE_FINGERPRINT to the friendly-copy map, so the reported user sees "This device has already been used to verify another account" instead of Didit's raw short_description.
  • REJECTED / INCOMPLETE / under_review branches key off the formatted result instead of the raw warnings.length, so a warning set that produces no display text no longer renders an empty - bullet.
  • Comment tidy on the under_review branch.

All attached warnings are shown — no log_type filtering.

Note on the missing button

The disabled "Under Review" button already renders for a Didit under_review user (getStepButtonText"Under Review", disabled). The screenshot's denied copy + no button is the Rain DENIED render, which only appears if rainApplicationStatus: "denied" reaches the client. If this under_review user still shows the denied screen on a fresh build, share the /cards/status response and I'll trace it.

ESLint passes. kycDisplayHelpers.ts is kept identical to the qa-targeted branch (#2125).

https://claude.ai/code/session_01S2muieprRUo3BGSh8yKBtR

@vercel

vercel Bot commented Jun 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
solid-app Ignored Ignored Preview Jun 7, 2026 9:43am
solid-app-staging Ignored Ignored Preview Jun 7, 2026 9:43am

Request Review

@MusabShakeel576
MusabShakeel576 force-pushed the claude/kyc-under-review-warnings-master branch from 17e2a65 to a2d53de Compare June 7, 2026 09:41
…nder review

For a Didit under_review user (e.g. held due to a duplicate device/IP), step 1
of /card/activate now lists the attached warning reasons instead of a generic
"being reviewed" message.

- The under_review step-1 description surfaces the attached warnings
  ("Your application is under additional review: ...") with a fallback to the
  generic "few minutes" copy when there are none.
- REJECTED / INCOMPLETE / under_review branches key off the formatted result so
  a text-less warning set no longer renders an empty bullet list.
- Add DUPLICATED_DEVICE_FINGERPRINT to the friendly-copy map.

Keeps kycDisplayHelpers.ts identical to the qa branch.

https://claude.ai/code/session_01S2muieprRUo3BGSh8yKBtR
@MusabShakeel576
MusabShakeel576 force-pushed the claude/kyc-under-review-warnings-master branch from a2d53de to c769978 Compare June 7, 2026 09:43
@MusabShakeel576 MusabShakeel576 changed the title Surface only decision-affecting KYC warnings on step 1 (incl. under-review) (master) Surface Didit KYC warnings on step 1, including under-review (master) Jun 7, 2026
@MusabShakeel576
MusabShakeel576 merged commit 412bc18 into master Jun 7, 2026
4 of 5 checks passed
@MusabShakeel576
MusabShakeel576 deleted the claude/kyc-under-review-warnings-master branch June 7, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants