PREQ-7525 Fail promote job when multi-repo promotion API call returns an error

[henryju]

Summary

• We just hit a case on sonar-scanner-engine PR #525 where the Promote job (with multi-repo: true) reported success on GitHub, but the actual JFrog multiRepoPromote plugin call returned a 404 (The execution name 'multiRepoPromote' could not be found.). Because promote_multi() only printed the curl response without inspecting it, the failure was silently swallowed, the artifact was never promoted to sonarsource-private-dev, and the downstream deploy job failed later with a confusing "no artifact found" error.
• This makes promote_multi() check the JSON response for an errors field and fail the step (with a clear ::error:: annotation) when the Artifactory plugin call itself fails, instead of only failing much later in an unrelated deploy job.

Test plan

• ./run_shell_tests.sh (via mise exec -- shellspec spec/promote_spec.sh --shell bash) — 32 examples, 0 failures, including a new case simulating the exact 404 response seen in the wild
• shellcheck promote/promote.sh — clean

🤖 Generated with Claude Code

[hashicorp-vault-sonar-prod]

PREQ-7525

[Copilot]

Pull request overview

Ensures the multi-repo Artifactory promotion step fails fast (and annotates the workflow) when the multiRepoPromote plugin returns an error response, preventing silent “success” in GitHub Actions that later causes confusing downstream failures.

Changes:

• Capture and print the jf rt curl response in promote_multi(), and fail the step when the JSON response contains an errors field.
• Add ShellSpec coverage for the real-world 404 plugin error response case.
• Extend the ShellSpec jq mock to support the new .errors checks.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
promote/promote.sh	Adds JSON error detection/step failure logic for multi-repo promotion responses.
spec/promote_spec.sh	Adds tests and mock behavior to validate failing on multi-repo promotion error responses.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 New dependency risks

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[gitar-bot]

Code Review ✅ Approved 2 resolved / 2 findings

Adds error handling to the multi-repo promotion API call to fail the job when Artifactory returns an error, addressing the non-JSON/empty-errors edge cases and single-line annotation formatting.

✅ 2 resolved

✅ Edge Case: Non-JSON / hard curl failures still slip through

📄 promote/promote.sh:137-142
jq -e '.errors' only detects failure when the response is valid JSON containing an errors field. If jf rt curl returns a non-JSON body (e.g. an HTML gateway error or empty output on a transient failure), jq exits non-zero, the if is false, and promote_multi returns success — reintroducing the silent-swallow bug for that failure mode. Note the plugin returned a JSON body here so this path is covered, but consider also validating that jf rt curl succeeded and the response parses as JSON (e.g. jq -e 'type=="object"') before concluding success.

✅ Edge Case: An empty errors array would be treated as a failure

📄 promote/promote.sh:139
jq -e '.errors' returns exit 0 for any value that is not null/false, including an empty array []. If the multiRepoPromote plugin ever returns {"errors": []} on success, this would wrongly fail the promote step. If that is a possibility, guard against it with something like jq -e '.errors | length > 0' so only a non-empty error list triggers the failure.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}