PREQ-7525: Accept plain-text success from multiRepoPromote

[tomverin]

Summary

• Regression in 1.8.6 (#329): promote_multi() required a JSON object response, but multiRepoPromote.groovy returns plain text on success (Promoted <build> <number> from …).
• Concrete failure: sonarqube-unification promote — artifacts were promoted, then the job failed with Unexpected non-JSON response.
• Fix: treat responses starting with Promoted as success; still fail on JSON errors and other non-JSON bodies (e.g. Bad Gateway).
• Jira: PREQ-7525

Test plan

• shellspec spec/promote_spec.sh --shell bash (35 examples, 0 failures)
• shellcheck promote/promote.sh
• CI on this PR
• After release 1.8.7 + v1 update, re-run multi-repo promote (e.g. sonarqube-unification)

[hashicorp-vault-sonar-prod]

PREQ-7525

[gitar-bot]

Code Review ✅ Approved

Updates promote_multi() to accept plain-text success responses starting with 'Promoted ', fixing the JSON parsing regression caused by the artifactory user plugin update. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[Copilot]

Pull request overview

Adjusts the Artifactory multi-repo promotion step to tolerate the multiRepoPromote plugin’s real-world success output (plain-text Promoted ...) while preserving failure detection via JSON errors, addressing a regression introduced in 1.8.6.

Changes:

• Update promote_multi() to treat plain-text responses starting with Promoted as success.
• Keep failing behavior for JSON responses that contain non-empty .errors, and for unexpected non-JSON bodies.
• Update/extend ShellSpec coverage to reflect plain-text success responses from multiRepoPromote.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
promote/promote.sh	Accepts Promoted ... plain-text as success while retaining JSON errors handling and robust error reporting for unexpected bodies.
spec/promote_spec.sh	Updates mocks/expectations for plain-text success and adds a dedicated test case for the Promoted ... response.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 New dependency risks

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud