Text Link Issues with Obsidian Communication Entry

[tikool17]

Description

A few issues with text links in the new communication wizard as detailed below:

Actual Behavior

-Spaces in filenames from the File Manager aren't being URL encoded - which breaks links
-https:// is being inserted to local file paths on edits to those links - which break links
-Saving edits to links is unclear

Expected Behavior

-Links to assets should account for spaces in folder names
-The edit link pop up needs to be smart enough to recognize local assets and not prepend https:// (or don't use local file paths and just use full urls)
-The edit link pop up should have a "save" button or similar

Steps to Reproduce

Issue 1:

• Create an email in the new communication entry
• In a paragraph text block select and add a file via the "File Browser" icon - and choose one from a folder that has a space in the folder name like "Connect Groups"
• The link is inserted with a blank space. This differs from the Legacy text link process which replaces spaces with "%20"

New:

Legacy:

• When sent this space is converted to a "+" which breaks the link.

Issue 2:

• when editing a text link with a local path as is generated from the file picker, upon saving any change it prepends a "https://" which also will break the link. (I was trying to manually add the %20 to fix the link)

Issue 3: (more of UI/UX consideration, at least on Safari where I'm testing)

• the edit link pop up doesn't have a clear way of saving edits. If you make a change and then click off of the pop up it reverts and is unsaved. Hitting Return saves it (and inserts Issue 2 above), but I would expect a "Save" button or something.

Thank ya'll!

Issue Confirmation

• Perform a search on the Github Issues to see if your bug is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

18.1

Client Culture Setting

en-US