Skip to content

Comments

+ Fix Obsidian and Obsidian Block building#5258

Closed
jamessandison wants to merge 1 commit intoSparkDevNetwork:developfrom
jamessandison:obsidian-build-fixes
Closed

+ Fix Obsidian and Obsidian Block building#5258
jamessandison wants to merge 1 commit intoSparkDevNetwork:developfrom
jamessandison:obsidian-build-fixes

Conversation

@jamessandison
Copy link

@jamessandison jamessandison commented Jan 2, 2023

Notice

We cannot guarantee that your pull request will be accepted. There are many factors involved. We take into consideration whether or not the Rock system you run is a standard, main-line build. If it is not, there is a lower chance we will accept your request (since it may impact a part of the system you don't regularly use). Features that would be used by less than 80% of Rock organizations, or ones that don't match the goals of Rock, are other important factors.

Proposed Changes

Fixes: #5257
Allows the build in Visual Studio 2022 to complete successfully, specifically the Obsidian and Obsidian Block solutions.
Sorry if this is wrong/not correct - this is my first PR here and I've never used C# or ASP.NET before, and I've never used Visual Studio for Node/Javascript development.

Types of changes

What types of changes does your code introduce to Rock?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality, which has been approved by the core team)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • This is a single-commit PR. (If not, please squash your commit and re-submit it.)
  • I verified my PR does not include whitespace/formatting changes -- because if it does it will be closed without merging.
  • I have read the Contributing to Rock doc
  • By contributing code, I agree to license my contribution under the Rock Community License Agreement
  • Unit tests pass locally with my changes
  • I have added any required unit tests or integration tests that prove my fix is effective or that my feature works
  • I have included updated language for the Rock Documentation (if appropriate)

Further comments

Documentation

Migrations

If your pull request requires a migration, please exclude the migration from the Rock.Migration project, but submit it with your pull request. Please add a note to your pull request that provides a heads up that a migration file is present.

@jamessandison
Copy link
Author

jamessandison commented Jan 2, 2023

I believe the cause of the issue may be to do with Rollup and potentially the version used? Because I just installed the Rock packages, the Rollup version may have changed which changed its support for 'importing' modules? rollup/rollup#3443
I am currently using Rollup v2.70.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Obsidian & Obsidian Blocks fail to build

2 participants