+ Fix Obsidian and Obsidian Block building#5258
Closed
jamessandison wants to merge 1 commit intoSparkDevNetwork:developfrom
Closed
+ Fix Obsidian and Obsidian Block building#5258jamessandison wants to merge 1 commit intoSparkDevNetwork:developfrom
jamessandison wants to merge 1 commit intoSparkDevNetwork:developfrom
Conversation
Author
|
I believe the cause of the issue may be to do with Rollup and potentially the version used? Because I just installed the Rock packages, the Rollup version may have changed which changed its support for 'importing' modules? rollup/rollup#3443 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notice
We cannot guarantee that your pull request will be accepted. There are many factors involved. We take into consideration whether or not the Rock system you run is a standard, main-line build. If it is not, there is a lower chance we will accept your request (since it may impact a part of the system you don't regularly use). Features that would be used by less than 80% of Rock organizations, or ones that don't match the goals of Rock, are other important factors.
Proposed Changes
Fixes: #5257
Allows the build in Visual Studio 2022 to complete successfully, specifically the Obsidian and Obsidian Block solutions.
Sorry if this is wrong/not correct - this is my first PR here and I've never used C# or ASP.NET before, and I've never used Visual Studio for Node/Javascript development.
Types of changes
What types of changes does your code introduce to Rock?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Documentation
Migrations
If your pull request requires a migration, please exclude the migration from the Rock.Migration project, but submit it with your pull request. Please add a note to your pull request that provides a heads up that a migration file is present.