Add catalogue-based probe construction for OpenEphys and channel map ordering#409
Merged
h-mayorquin merged 46 commits intoSpikeInterface:mainfrom Mar 18, 2026
Merged
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…' into separate_open_ephys
for more information, see https://pre-commit.ci
…' into separate_open_ephys
… adc check in tests, plugin_channe_keys -> settings_channel_keys
for more information, see https://pre-commit.ci
…erface into separate_open_ephys
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…' into separate_open_ephys
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…-map-ordering' into openephys-channel-map-ordering
h-mayorquin
approved these changes
Mar 18, 2026
Collaborator
h-mayorquin
left a comment
h-mayorquin
left a comment
There was a problem hiding this comment.
LGTM
I removed a function that I introduced for the oebin structure _contact_id_to_global_electrode_index and modified the relates tests.
…annel-map-ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #406
In #406, the
read_openephyswas refactored to use the probe from the catalogue and then slice it. In addition, it attempts to solve a mismatch between the channel order in the settings file and structure.oebin file (see SpikeInterface/spikeinterface#4394), by using thestructure.oebinfileelectrode_indexfield to set device channel indices. This comes with a lot of additional logic (that we thought was required).I was checking again the
settings.xmland had a eureka moment! The mismatch is not random, but it's due to a "Channel Map" processor preceding the "Record Node"! If we simply read the custom channel map and apply it when we slice the probe, this magically fix all issues, with a much simpler solution and without requiring the additional oebin file. Then we can apply the defaultarangefor device channel indices.You can see the changes with #406 here
All tests with the
structure.oebinare kept!