Update read_openephys and add OneBox tests#4456
Open
alejoe91 wants to merge 23 commits intoSpikeInterface:mainfrom
Open
Update read_openephys and add OneBox tests#4456alejoe91 wants to merge 23 commits intoSpikeInterface:mainfrom
read_openephys and add OneBox tests#4456alejoe91 wants to merge 23 commits intoSpikeInterface:mainfrom
Conversation
Collaborator
|
Maybe we can add a test here: |
alejoe91
changed the title
read_openephysread_openephys and add OneBox tests
…interface into oebin-for-openephys-probe
h-mayorquin
approved these changes
Mar 18, 2026
Collaborator
h-mayorquin
left a comment
h-mayorquin
left a comment
There was a problem hiding this comment.
LGTM.
I tested this with the branch SpikeInterface/probeinterface#409 and it workfor me
Let's merge the probeinterface PR and see that the tests pass.
|
|
||
|
|
||
| def get_neuropixels_sample_shifts_from_probe(probe: Probe, stream_name: str = "ap") -> np.ndarray: | ||
| def get_neuropixels_sample_shifts_from_probe(probe: Probe) -> np.ndarray: |
Collaborator
There was a problem hiding this comment.
wouldn't this break for some people if they are using this function? if we think they are not should we make this private?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
Requires SpikeInterface/probeinterface#409
In SpikeInterface/probeinterface#409 we improved the matching and sorting of device channel indices when a channel map is present (as in #4394). Now te probeinterface reader handles the re-ordering of contacts, so we don't need any additional logic on the SI side.
Added tests for OneBox, including the "non-trivial" wiring. In the latter test, we check that the recording channel ids (from the oebin) correspond to the
settings_channel_keyannotation, which has been sorted according to the channel map