Kilosort v4.0.34 added `shank_idx` to `set_files()`, which breaks support with spikeinterface

[JarrodDowdall]

Kilosort has added shank_idx to allow sorting shanks separately, but this does not appear to be supported in spikeinterface yet.

MouseLand/Kilosort@339fb66

Because set_files() now expects shank_idx, running kilosort4 with spikeinterface returns the error:

spikeinterface/sorters/external/kilosort4.py", line 255, in _run_from_folder
    filename, data_dir, results_dir, probe = set_files(
                                             ^^^^^^^^^^
TypeError: set_files() missing 1 required positional argument: 'shank_idx'

spikeinterface/src/spikeinterface/sorters/external/kilosort4.py

Lines 255 to 263 in ed07e25

	filename, data_dir, results_dir, probe = set_files(
	settings=settings,
	filename=filename,
	probe=probe,
	probe_name=probe_name,
	data_dir=data_dir,
	results_dir=results_dir,
	bad_channels=bad_channels,
	)

In Kilosort v4.0.33 the inputs to set_files() are:

def set_files(settings, filename, probe, probe_name,
              data_dir, results_dir, bad_channels):

So kilosort v4.0.33 works with spikeinterface.

But from Kilosort v4.0.34 forward they are:

def set_files(settings, filename, probe, probe_name, data_dir, results_dir,
              bad_channels, shank_idx):

https://github.com/MouseLand/Kilosort/blob/2586930f0098acb0829a5e73f2f25bcc6ce792ed/kilosort/run_kilosort.py#L349

[zm711]

Thanks for the report. KS4 changes pretty quick so if you feel confident of the fix feel free to open a PR. Our test suite will check all versions (4.16+) to ensure that it is backward compatible. I can look into this a bit more soon, but I'm at least too busy at the moment.