Fix ks4 tests and support ks4>=4.0.34#3900
Conversation
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
Looks fine to me and tests are passing :)
I only wish we could find a way to help deal with the changing number of arguments. Your idea of setting a kwargs_dict seems cool, I wonder if we can apply that in more places such that the dict changes with the versions so when we unpack it, it returns the correct things. Maybe for a future PR we think about that :)
|
|
||
| if self.whiten_mat is not None: | ||
| pass | ||
| return X |
There was a problem hiding this comment.
This is brutal..... Sorry. didn't highlight what I wanted it to. I meant the fact you had to duplicate the function because an used argument change.
There was a problem hiding this comment.
Hopefully this doesn't happen too soon! Anyways, kudos to @JoeZiminski since the tests to check the arguments of different KS functions are very useful to understand what's changed!
2 participants
"templates_from_data"from testing (since it results in failures: BUG: Issue downloading "https://www.kilosort.org/downloads/wTEMP.npz": URL not found MouseLand/Kilosort#932)