Skip to content

Test IBL skip when the setting up the one client fails - #3289

Merged
alejoe91 merged 2 commits into
SpikeInterface:mainfrom
h-mayorquin:fix_streaming_test
Aug 6, 2024
Merged

Test IBL skip when the setting up the one client fails#3289
alejoe91 merged 2 commits into
SpikeInterface:mainfrom
h-mayorquin:fix_streaming_test

Conversation

@h-mayorquin

Copy link
Copy Markdown
Contributor

Seeing if this works.

@h-mayorquin h-mayorquin added extractors Related to extractors module testing Related to test routines labels Aug 6, 2024
@h-mayorquin h-mayorquin self-assigned this Aug 6, 2024
@h-mayorquin

Copy link
Copy Markdown
Contributor Author

This seems to be working but I am concerned because the tests are passing for me locally without this. That is, I run:

(work) @h-laptop$ pytest /.../src/spikeinterface/extractors/tests/test_iblextractors.py

I wonder why the requests from github are being blocked. I wonder if it is a new policy of ibl?

@alejoe91

alejoe91 commented Aug 6, 2024

Copy link
Copy Markdown
Member

@h-mayorquin I think that webclient has some internal caching mechanism. I'm getting this warning on my side:

/home/alessio/anaconda3/envs/si/lib/python3.10/site-packages/one/webclient.py:126: RuntimeWarning: Failed to connect, returning cached response
  warnings.warn('Failed to connect, returning cached response', RuntimeWarning)

@h-mayorquin

Copy link
Copy Markdown
Contributor Author

So you think is passing for me locally because I have something cached?

@h-mayorquin

Copy link
Copy Markdown
Contributor Author

Then I guess this should work. We should just be weary of the test not every working again : P

@alejoe91

alejoe91 commented Aug 6, 2024

Copy link
Copy Markdown
Member

Thanks @h-mayorquin

I really like the smart solution! :)

@alejoe91
alejoe91 merged commit 9d6ad5b into SpikeInterface:main Aug 6, 2024
@h-mayorquin
h-mayorquin deleted the fix_streaming_test branch August 6, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extractors Related to extractors module testing Related to test routines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants