Test IBL skip when the setting up the one client fails - #3289
Merged
Conversation
Contributor
Author
|
This seems to be working but I am concerned because the tests are passing for me locally without this. That is, I run: (work) @h-laptop$ pytest /.../src/spikeinterface/extractors/tests/test_iblextractors.pyI wonder why the requests from github are being blocked. I wonder if it is a new policy of ibl? |
Member
|
@h-mayorquin I think that webclient has some internal caching mechanism. I'm getting this warning on my side: |
Contributor
Author
|
So you think is passing for me locally because I have something cached? |
Contributor
Author
|
Then I guess this should work. We should just be weary of the test not every working again : P |
alejoe91
approved these changes
Aug 6, 2024
Member
|
Thanks @h-mayorquin I really like the smart solution! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing if this works.