Fix sortingview curation no merge case - #3309
Merged
Merged
Conversation
alejoe91
reviewed
Aug 20, 2024
rkim48
force-pushed
the
sortingview-curation-fix
branch
from
August 20, 2024 16:05
dee9d61 to
d029f7d
Compare
alejoe91
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3308
In the case where no merges are made in sortingview, two errors are thrown.
First error is due to sortingview not returning a curation_dict with a "mergeGroups" key which hopefully I fixed.
Second error is due to type mismatch between labeled units and unit list. This one still needs to be fixed.
Edit: Second error fixed. I believe this PR is ready to be reviewed.