Fix codecov tests - #3569
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3569 +/- ##
==========================================
+ Coverage 71.57% 71.69% +0.12%
==========================================
Files 311 311
Lines 36179 36232 +53
==========================================
+ Hits 25894 25978 +84
+ Misses 10285 10254 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
h-mayorquin
approved these changes
Dec 4, 2024
| done | ||
|
|
||
| - name: Set testing environment # This decides which tests are run and whether to install especial dependencies | ||
| - name: Set testing environment # This decides which tests are run and whether to install special dependencies |
Contributor
There was a problem hiding this comment.
My Spanish speaking self came out yelling on this one.
Contributor
|
The failing tests seem to be IBL : / |
zm711
approved these changes
Dec 5, 2024
zm711
left a comment
zm711
left a comment
Member
There was a problem hiding this comment.
This also looks good to me :) It'll be nice to have the green box again !
Member
Author
Pinned one-api... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thansk for the hint @h-mayorquin
Tests passing: https://github.com/SpikeInterface/spikeinterface/actions/runs/12157608869