Allow for concatenated mode in get_some_projections and compute_pc_metrics - #3670
Merged
Merged
Conversation
alejoe91
approved these changes
Feb 5, 2025
Contributor
|
Just tested it and it works, thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #3653
Fixes bug where
get_some_projectionsandcompute_pc_metricscouldn't extract pcas when they were computed in concatenated mode. Fixing this allows pca quality metrics to be computed too.Added a test which used to fail, and now passes.
Harder to test if this definitely works. Here's some evidence: it's code which computes the quality metrics in
concatenatedmode (with 20 components) and in non-concatenated mode (with5x4=20components), then computes the metrics. We wouldn't expect the results to be equal, but would expect them to be highly correlated, which they seem to be!with output: