Rename neurodsp to ibldsp to ensure IBL tests run#4392
Rename neurodsp to ibldsp to ensure IBL tests run#4392samuelgarcia merged 4 commits intoSpikeInterface:mainfrom
neurodsp to ibldsp to ensure IBL tests run#4392Conversation
Add pooch and datalad dependencies for IBL data fetching
pyproject.toml
Outdated
| "pooch", | ||
| "datalad" |
There was a problem hiding this comment.
I'm kinda confused why these weren't here already. I don't think neurodsp depended on them.
There was a problem hiding this comment.
Oh yea I thought so too, they are actually already there! under test_extractors. This test checks on real data so it would be nice to include these dependencies in the general test dependencies if possible. I can't remember the reason except real data is used here, to test under real conditions which is kind of nice especially for debugging. That been said not opposed to removing it if its going to cause a lot of problems for test infrastrcture @samuelgarcia @alejoe91
There was a problem hiding this comment.
I think it's ok to add it, but we could also add it selectively to the test_preprocessing section, so it only installs for it. @JoeZiminski what do you think?
There was a problem hiding this comment.
Yes sounds good to me, cheers @alejoe91!
|
Merci Joe. |
4 participants
The IBL
neurodspwas renamed toibldspand so the IBL tests stopped running. I renamed this, but also made some other changes that I will will break the tests due to dependcy issues. Lets see...