Skip to content

quick fix for spikeglx probe#596

Merged
samuelgarcia merged 12 commits intoSpikeInterface:masterfrom
catalystneuro:spike_lgx_probe_logic
May 25, 2022
Merged

quick fix for spikeglx probe#596
samuelgarcia merged 12 commits intoSpikeInterface:masterfrom
catalystneuro:spike_lgx_probe_logic

Conversation

@h-mayorquin
Copy link
Copy Markdown
Collaborator

@alejoe91 and I were discussing today the loading of the probe geometry for spikeglx. These are the requested changes.

@samuelgarcia
Copy link
Copy Markdown
Member

Hi Herberto.
Thanks for this. I do commtn in place

Comment thread spikeinterface/extractors/neoextractors/spikeglx.py Outdated
Comment thread spikeinterface/extractors/neoextractors/spikeglx.py Outdated
Comment thread spikeinterface/extractors/neoextractors/spikeglx.py Outdated
Comment thread spikeinterface/extractors/neoextractors/spikeglx.py
@h-mayorquin
Copy link
Copy Markdown
Collaborator Author

The meta file corresponding to the lf stream in the testing data does not have a snsShankMap and therefore the test fails.

How do you want to handle this?

@alejoe91
Copy link
Copy Markdown
Member

The meta file corresponding to the lf stream in the testing data does not have a snsShankMap and therefore the test fails.

How do you want to handle this?

In that case what I would do (in spikeinterface) is to look for the corresponding AP file and load the probe from there. What do you think?

@h-mayorquin
Copy link
Copy Markdown
Collaborator Author

In that case what I would do (in spikeinterface) is to look for the corresponding AP file and load the probe from there. What do you think?

Yes, I think that makes sense. Is there any reason to expect those two files to be different. The few meta files that I have seen are mostly identical in all the properties. Maybe you know more about this.

@alejoe91
Copy link
Copy Markdown
Member

Yeah the LF doesn't have the shank map! Which is used to construct channel locations (hence the error)

@alejoe91
Copy link
Copy Markdown
Member

Yeah the LF doesn't have the shank map! Which is used to construct channel locations (hence the error)

@h-mayorquin do you have time to try to implement this? basically look for the ap file with the same stem as the lf file and load the probe from there (if lf in stream_id)

@h-mayorquin
Copy link
Copy Markdown
Collaborator Author

h-mayorquin commented May 20, 2022

I implemented the requested changes. There seems to be a different error. This was working locally for me with the Sam tests in gin. I will take a look later but meanwhile maybe you have an idea on what this could be.

Where are the instructions to run the tests locally? You used a different data structure for the tests than the one in neo or nwb-conversion-tools and I think I lost the location of the tests directory, do you have an utilities to set up the testing suit?

@alejoe91
Copy link
Copy Markdown
Member

@h-mayorquin we should skip the probe loading if the steam is nidq

Comment thread spikeinterface/extractors/neoextractors/spikeglx.py
@alejoe91
Copy link
Copy Markdown
Member

@samuelgarcia removed the try - except. Shold be good to go now!

@samuelgarcia samuelgarcia merged commit 9de6680 into SpikeInterface:master May 25, 2022
@h-mayorquin h-mayorquin deleted the spike_lgx_probe_logic branch June 24, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants