Disable two tasks by default with FeatureFlag OLD_TASKS#584
Closed
jmfayard wants to merge 1 commit into
Closed
Conversation
refreshVersionsDependenciesMapping never used it, nobody used it according to google search migrateToRefreshVersionsDependenciesConstants we now have refreshVersionsMigrate
thederputy
pushed a commit
to thederputy/refreshVersions
that referenced
this pull request
Oct 2, 2022
Closes Splitties#584 Co-authored-by: Louis CAD <louis.cognault@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have two mostly obsolete tasks
refreshVersionsDependenciesMappingwas never really useful (I never used it) and is now fully replaced by the web page https://jmfayard.github.io/refreshVersions/dependencies-notations/migrateToRefreshVersionsDependenciesConstantswho was the precursor torefreshVersionsMigrateWithout them the tasks look cleaner:
On the other hand we never know, someone might use those tasks.
So instead of removing them, I put them behind a feature flag disabled by default