EnchantItemEvent

[Faithcaio]

SpongeAPI | SpongeCommon

3 new Events:

• EnchantItemEvent.CalculateLevelRequirement first event ; calculates the level requirement for each enchant
• EnchantItemEvent.CalculateEnchantment second event ; calculates the list of enchantments to apply - fires twice - once for the preview then again when actually enchanting - plugins should return the same list for the same input
• EnchantItemEvent.Post the final event ; contains the slot transactions of the enchanted item getting changed and the lapis used.

For reference:
#1303

[liach]

Beyond all these issues, you need to remove the implnotes from the api.

[liach]

Can curse be optional as well?

[Faithcaio]

Look like curses are treasure enchantments.
Not allowing curses would require us to write our own version for getting random enchantments.

[kashike]

Treasure and Curse are separate - there are only two curses (binding_curse, vanishing_curse), while there are 4 treasures (binding_curse, frost_walker, mending, vanishing_curse).

[Faithcaio]

EnchantmentHelper#buildEnchantmentList(Random randomIn, ItemStack itemStackIn, int level, boolean allowTreasure) doesn't allow filtering curses.
We can still add it to the API if its doable.

[Zidane]

getOutputSlot instead? How do we want to word these? Other Tiles that have logic could have similar events (like the Anvil one we already do)

[Faithcaio]

Its the also the input slot.

[Zidane]

Maybe call this Post? The docs imply the action occurred, the name of the event implies it is about to occur.

[Zidane]

The below two methods feel like they belong elsewhere. What if I want to build an EnchantmentList but in my code I don't have an EnchantmentList already on hand? How would I do this?

[Faithcaio]

Atm. you cant do it.
I guess if you wanted to emulate an enchanting table somewhere else you might need this.
We would have to expose it in some kind of builder class then?