Force Python 3 test failures to fail the build#81
Conversation
|
Am I wrong or should this really require a script to create a PR in each pack repo to resolve broken py3 tests? Is it reasonable to expect the next person that happens to do a PR to have to fix the tests? |
|
Yeah we really need tooling to help with that. In Puppet land we use either modulesync or PDK. Basically both tools have a 'template" repo they base off of, then when you run the sync it clones your main repo and syncs with the template. Modulesync, I believe, also had the ability to make changes over a big list of repos. Think of this like cookiecutter on steroids. https://github.com/voxpupuli/modulesync https://github.com/puppetlabs/pdk I'm sure we could use these tools. Not sure if writing something ourselves is worthwhile? |
|
You're not wrong, but I'm the one working on fixing all packs that don't work on Python 3. It's a long story, but I was going to merge this in before our weekly pack CI runs (which test every Python file in the pack, and not just changed Python files like the PR tests do) this weekend, so I could see packs actually fail. And I plan on reverting this on Monday. The way we have it setup now, the Python 3 PRs can pass, but once you merge into the pack |
|
Tested this with the AWS pack, results here: I'm going to merge this in for the weekend pack CI runs, and then revert it on Monday. |
|
I should also add that for pack PRs this weekend, the CircleCI builds will only fail (due to this change) if they touch a module that is not Python 3 compliant and do not fix the module themselves (because CI runs for PRs only check files that are changed in the PR itself, not all files). Since most of our pack PRs happen on weekdays, and our CI for PRs only checks changed files, I think the impact on other users will be minimal this weekend. |
|
I do like the idea of running them with weekly then reverting to have a hit list for remediation.
Cheers,
JP
… On Jan 31, 2020, at 10:49 PM, blag ***@***.***> wrote:
I should also add that for pack PRs this weekend, the CircleCI builds will only fail (due to this change) if they touch a module that is not Python 3 compliant and do not fix the module themselves (because CI runs for PRs only check files that are changed in the PR itself, not all files).
Since most of our pack PRs happen on weekdays, and our CI for PRs only checks changed files, I think the impact on other users will be minimal this weekend.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
3 participants
No description provided.