Add obj type in search result and indicating SIMBAD result by henrysky · Pull Request #4635 · Stellarium/stellarium

henrysky · 2025-11-05T05:02:13Z

Description

I have

added which module the objects come from in the search result
indicating which results are from SIMBAD and what are their SIMBAD obejct types

Fixes #4531

Screenshots (if appropriate):

Searching Hercules:

Searching M31 which can be from local or SIMBAD:

Searching Kepler-451 which exists locally (with Gaia DR3 ID from SIMBAD):

Searching Kepler-452b which does not exist locally:

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
This change requires a documentation update
Housekeeping

How Has This Been Tested?

See above

Test Configuration:

Operating system: MacOS 26.1
Graphics Card: Apple M3

Checklist:

My code follows the code style of this project.
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (header file)
I have updated the respective chapter in the Stellarium User Guide
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

…object types

github-actions · 2025-11-05T05:03:00Z

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

alex-w · 2025-11-05T16:23:16Z

I’m not sure - should be object type translatable in list of matches (in a DisplayRole list)?

P.S. Of course, user can find objects by their designation, English name or localized name

alex-w · 2025-11-05T16:27:58Z

Searching Kepler-451 which exists locally (with Gaia DR3 ID from SIMBAD):

I see answer from SIMBAD only and I should ask - where is locally item?

alex-w

thanks!

henrysky · 2025-11-05T23:58:30Z

Searching Kepler-451 which exists locally (with Gaia DR3 ID from SIMBAD):

I see answer from SIMBAD only and I should ask - where is locally item?

What I meant is Kepler-451 is Gaia DR3 2080063931448749824 (Gaia ID retrieved from SIMBAD). So searching Kepler-451 will get you to Gaia DR3 2080063931448749824 which has proper motion, distance, etc. in Stellarium. As opposed to searching Kepler-452b which will point to a custom object.

10110111 · 2025-11-06T03:28:51Z

 	class SimbadSearcher* simbadSearcher;
 	class SimbadLookupReply* simbadReply;
 	QMap<QString, Vec3d> simbadResults; //! Simbad object name and J2000.0 coordinates
+	QMap<QString, QString> simbadObjectTypes; //! Simbad object name and object type


Why does this have to be kept as a data member? The only time it's used is when it's just been written, never re-used anywhere else.

simbadObjectTypes is used in onSimbadStatusChanged() and gotoObject() now (after you made the review).

10110111 · 2025-11-06T03:32:12Z

If SIMBAD object types is a stable list, it may make sense to declare all of them with QT_TR_NOOP and use q_() to translate them.

alex-w · 2025-11-06T07:11:52Z

If SIMBAD object types is a stable list, it may make sense to declare all of them with QT_TR_NOOP and use q_() to translate them.

It's not very stable, but yes, it has a low temp of changes and we can add all these items as data for translations (to use in q_() to translate).

alex-w · 2025-11-06T07:50:09Z

I fear the feature for recent objects should be updated too to avoid troubles of search the synonyms - at the moment it storing the list of names only.

github-actions · 2025-11-06T07:51:04Z

Hello @henrysky!

Thank you for the suggested improvement.

- SIMBAD object types are translatable now - added few SIMBAD object types with context

alex-w · 2025-11-08T08:47:24Z

@henrysky SIMBAD object types are translatable now (the taxonomy is not completed yet)

10110111 · 2025-11-08T12:23:20Z

the taxonomy is not completed yet

What are the obstacles?

The following should complete the list, according to the otypes.list downloadable from the link you gave.

diff --git a/src/translations.h b/src/translations.h
index 54dd07e16e..7b178b2909 100644
--- a/src/translations.h
+++ b/src/translations.h
@@ -634,6 +634,72 @@ class Translations
         NC_("LBV=Luminous Blue Variable", "SIMBAD object type");
         NC_("Neutron Star", "SIMBAD object type");
         NC_("Pulsar", "SIMBAD object type");
+        NC_("Young Stellar Object", "SIMBAD object type");
+        NC_("Orion Variable", "SIMBAD object type");
+        NC_("T Tauri Star", "SIMBAD object type");
+        NC_("Herbig Ae/Be Star", "SIMBAD object type");
+        NC_("Outflow", "SIMBAD object type");
+        NC_("Herbig-Haro Object", "SIMBAD object type");
+        NC_("Main Sequence Star", "SIMBAD object type");
+        NC_("Be Star", "SIMBAD object type");
+        NC_("Blue Straggler", "SIMBAD object type");
+        NC_("SX Phe Variable", "SIMBAD object type");
+        NC_("gamma Dor Variable", "SIMBAD object type");
+        NC_("delta Sct Variable", "SIMBAD object type");
+        NC_("Evolved Star", "SIMBAD object type");
+        NC_("Red Giant Branch star", "SIMBAD object type");
+        NC_("Hot Subdwarf", "SIMBAD object type");
+        NC_("Horizontal Branch Star", "SIMBAD object type");
+        NC_("RR Lyrae Variable", "SIMBAD object type");
+        NC_("Red Clump Star", "SIMBAD object type");
+        NC_("Type II Cepheid Variable", "SIMBAD object type");
+        NC_("Cepheid Variable", "SIMBAD object type");
+        NC_("Classical Cepheid Variable", "SIMBAD object type");
+        NC_("Carbon Star", "SIMBAD object type");
+        NC_("S Star", "SIMBAD object type");
+        NC_("Long-Period Variable", "SIMBAD object type");
+        NC_("Asymptotic Giant Branch Star", "SIMBAD object type");
+        NC_("Mira Variable", "SIMBAD object type");
+        NC_("O-rich AGB Star", "SIMBAD object type");
+        NC_("OH/IR Star", "SIMBAD object type");
+        NC_("Post-AGB Star", "SIMBAD object type");
+        NC_("RV Tauri Variable", "SIMBAD object type");
+        NC_("Planetary Nebula", "SIMBAD object type");
+        NC_("White Dwarf", "SIMBAD object type");
+        NC_("ELMWD=Extremely Low Mass White Dwarf", "SIMBAD object type");
+        NC_("Chemically Peculiar Star", "SIMBAD object type");
+        NC_("alpha2 CVn Variable", "SIMBAD object type");
+        NC_("R CrB Variable", "SIMBAD object type");
+        NC_("CH Star", "SIMBAD object type");
+        NC_("Barium Star", "SIMBAD object type");
+        NC_("Dwarf Carbon Star", "SIMBAD object type");
+        NC_("Carbon-Enhanced Metal Poor Star", "SIMBAD object type");
+        NC_("Double or Multiple Star", "SIMBAD object type");
+        NC_("Eclipsing Binary", "SIMBAD object type");
+        NC_("Ellipsoidal Variable", "SIMBAD object type");
+        NC_("Spectroscopic Binary", "SIMBAD object type");
+        NC_("RS CVn Variable", "SIMBAD object type");
+        NC_("BY Dra Variable", "SIMBAD object type");
+        NC_("Symbiotic Star", "SIMBAD object type");
+        NC_("X-ray Binary", "SIMBAD object type");
+        NC_("Low Mass X-ray Binary", "SIMBAD object type");
+        NC_("High Mass X-ray Binary", "SIMBAD object type");
+        NC_("Cataclysmic Binary", "SIMBAD object type");
+        NC_("Classical Nova", "SIMBAD object type");
+        NC_("SuperNova", "SIMBAD object type");
+        NC_("Low-mass Star", "SIMBAD object type");
+        NC_("Brown Dwarf", "SIMBAD object type");
+        NC_("Extra-solar Planet", "SIMBAD object type");
+        NC_("Variable Star", "SIMBAD object type");
+        NC_("Irregular Variable", "SIMBAD object type");
+        NC_("Irregular Variable with rapid variations", "SIMBAD object type");
+        NC_("Eruptive Variable", "SIMBAD object type");
+        NC_("Rotating Variable", "SIMBAD object type");
+        NC_("Pulsating Variable", "SIMBAD object type");
+        NC_("Star showing Eclipses by its Planet", "SIMBAD object type");
+        NC_("Emission-line Star", "SIMBAD object type");
+        NC_("High Proper Motion Star", "SIMBAD object type");
+        NC_("High Velocity Star", "SIMBAD object type");
         NC_("Cluster of Stars", "SIMBAD object type");
         NC_("Globular Cluster", "SIMBAD object type");
         NC_("Open Cluster", "SIMBAD object type");
@@ -671,6 +737,11 @@ class Translations
         NC_("Quasar", "SIMBAD object type");
         NC_("Blazar", "SIMBAD object type");
         NC_("BL Lac", "SIMBAD object type");
+        NC_("ULIRG, Ultra Luminous Infrared Galaxy", "SIMBAD object type");
+        NC_("Galaxy in Pair of Galaxies", "SIMBAD object type");
+        NC_("Galaxy towards a Group of Galaxies", "SIMBAD object type");
+        NC_("Galaxy towards a Cluster of Galaxies", "SIMBAD object type");
+        NC_("Brightest Galaxy in a Cluster (BCG)", "SIMBAD object type");
         NC_("Interacting Galaxies", "SIMBAD object type");
         NC_("Pair of Galaxies", "SIMBAD object type");
         NC_("Group of Galaxies", "SIMBAD object type");
@@ -680,12 +751,42 @@ class Translations
         NC_("Supercluster of Galaxies", "SIMBAD object type");
         NC_("Underdense Region of the Universe", "SIMBAD object type");
         NC_("Gravitational Source", "SIMBAD object type");
+        NC_("(Micro)Lensing Event", "SIMBAD object type");
+        NC_("Gravitational Lens System (lens+images)", "SIMBAD object type");
         NC_("Gravitational Lens", "SIMBAD object type");
+        NC_("Gravitationally Lensed Image", "SIMBAD object type");
+        NC_("Gravitationally Lensed Image of a Galaxy", "SIMBAD object type");
+        NC_("Gravitationally Lensed Image of a Quasar", "SIMBAD object type");
         NC_("Black Hole", "SIMBAD object type");
-        NC_("Gamma-ray Source", "SIMBAD object type");
-        NC_("X-ray Source ", "SIMBAD object type");
-        NC_("UV-emission Source", "SIMBAD object type");
+        NC_("Gravitational Wave Event", "SIMBAD object type");
+        NC_("Transient Event", "SIMBAD object type");
+        NC_("Variable source", "SIMBAD object type");
+        NC_("Radio Source", "SIMBAD object type");
+        NC_("Metric Radio Source", "SIMBAD object type");
+        NC_("Centimetric Radio Source", "SIMBAD object type");
+        NC_("Millimetric Radio Source", "SIMBAD object type");
+        NC_("Sub-Millimetric Source", "SIMBAD object type");
+        NC_("HI (21cm) Source", "SIMBAD object type");
+        NC_("Radio Burst", "SIMBAD object type");
         NC_("Maser", "SIMBAD object type");
+        NC_("Infra-Red Source", "SIMBAD object type");
+        NC_("Far-IR source (λ >= 30 µm)", "SIMBAD object type");
+        NC_("Mid-IR Source (3 to 30 µm)", "SIMBAD object type");
+        NC_("Near-IR Source (λ < 3 µm)", "SIMBAD object type");
+        NC_("Optical Source", "SIMBAD object type");
+        NC_("Emission Object", "SIMBAD object type");
+        NC_("Blue Object", "SIMBAD object type");
+        NC_("UV-emission Source", "SIMBAD object type");
+        NC_("X-ray Source", "SIMBAD object type");
+        NC_("Ultra-luminous X-ray Source", "SIMBAD object type");
+        NC_("Gamma-ray Source", "SIMBAD object type");
+        NC_("Gamma-ray Burst", "SIMBAD object type");
+        NC_("Composite Object, Blend", "SIMBAD object type");
+        NC_("Not an Object (Error, Artefact, ...)", "SIMBAD object type");
+        NC_("Part of Cloud", "SIMBAD object type");
+        NC_("Part of a Galaxy", "SIMBAD object type");
+        NC_("Object of Unknown Nature", "SIMBAD object type");
+        NC_("Region defined in the Sky", "SIMBAD object type");
 
         // =====================================================================
         // Translatable UI elements with comments for translators (extracomments)

alex-w · 2025-11-08T14:05:41Z

What are the obstacles?

I'm not sure that all of them are needed.

The following should complete the list, according to the otypes.list downloadable from the link you gave.

Good patch, please commit it

10110111 · 2025-11-08T14:14:27Z

Good patch, please commit it

How do I push to this branch? GitHub starts asking for a password when I try...

alex-w · 2025-11-08T14:34:47Z

How do I push to this branch? GitHub starts asking for a password when I try...

Ouch... GH allowing do it to me

10110111 · 2025-11-08T16:25:31Z

I was trying to check what type ULIRGs would have, and discovered that Gaia DR3 6286990861805968384 (AKA IRAS 14348-1447) is shown as a "custom object" in the info panel. Why is it so?

alex-w · 2025-11-08T16:30:23Z

I was trying to check what type ULIRGs would have, and discovered that Gaia DR3 6286990861805968384 (AKA IRAS 14348-1447) is shown as a "custom object" in the info panel. Why is it so?

The type “custom object” is assigned to any object, which found via SIMBAD and not exists in our local databases. But (!) now search tool retrieved object type and we can set correct object type for these objects (at least for actual session).

henrysky · 2025-11-08T16:39:27Z

(Update) Fixed in 1ed8077.

When I search for Kepler-452b and get the result from SIMBAD, it points to a location very
close to its host star (see below, with 25.3):

However, when I close and reopen Stellarium and simply click on Kepler-452b from the recent search list, it points to a slightly different location, a bit farther from its host star 🤔 (see below, with 25.3):

10110111 · 2025-11-08T16:46:10Z

With this PR, when I type a name into the Search input field, Stellarium hangs for a couple seconds, while without it it's much more responsive (although not smooth either).

…rong coordinates when re-load

henrysky · 2025-11-09T22:47:08Z

Now bothrecentObjectSearches.json and persistentCustomObjects.json store the retrieved object type from SIMBAD.

alex-w · 2025-11-10T04:43:06Z

+		if (!objType.isEmpty())
+		recentObjectSearchesData.objectTypes[nameI18n] = QString("SIMBAD; %1").arg(qc_(objType, "SIMBAD object type"));
+		else
+		recentObjectSearchesData.objectTypes[nameI18n] = q_("SIMBAD");


SIMBAD shouldn't be translated

alex-w · 2025-11-10T05:01:17Z

@henrysky please fix compiling with Qt5

P.S. The solution is acceptable, but I fear in future it will need cosmetic fix for l10n support

alex-w · 2025-11-11T03:54:51Z

Thanks!

github-actions · 2025-11-19T11:03:05Z

Hello @henrysky!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

github-actions · 2025-12-29T14:14:12Z

Hello @henrysky!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

The Search dialog is currently implemented in a very suboptimal way, especially since #4635, when it started triggering searches by name in its CompletionListModel::data method. The search is supposed to get object type for each item found, which is only a name of the object. What the dialog would really want is to have object pointers in the search results, not simply names. This requires a huge refactoring of the search API in StelObjectModule, so that the object listing methods return the object pointers. This is exactly what this change does. In addition to the pointers the API still returns the names, because it looks like the right names for search results are not always trivial to find out from the object itself. Fixes #4655.

add obj type in search result, indicating SIMBAD result with fetched …

5770742

…object types

github-actions Bot requested review from 10110111, alex-w and gzotti November 5, 2025 05:02

github-actions Bot assigned henrysky Nov 5, 2025

alex-w added this to the 25.4 milestone Nov 5, 2025

alex-w approved these changes Nov 5, 2025

View reviewed changes

10110111 reviewed Nov 6, 2025

View reviewed changes

alex-w added the enhancement Improve existing functionality label Nov 6, 2025

improvements for SIMBAD object types

f6f0a60

- SIMBAD object types are translatable now - added few SIMBAD object types with context

update src/translations.h file

6b96e80

henrysky added 2 commits November 9, 2025 17:18

save J2000 without aberration for custom object, otherwise slightly w…

1ed8077

…rong coordinates when re-load

add object type support for custom object

972d9e7

alex-w reviewed Nov 10, 2025

View reviewed changes

fix qt5 compilation

f908378

alex-w merged commit 5483017 into Stellarium:master Nov 11, 2025
15 of 16 checks passed

10110111 mentioned this pull request Nov 19, 2025

Search window is sluggish #4655

Closed

alex-w added the state: published The fix has been published for testing in weekly binary package label Nov 19, 2025

alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 29, 2025

10110111 mentioned this pull request Mar 14, 2026

Fix search window sluggishness #4819

Merged

Uh oh!

Conversation

henrysky commented Nov 5, 2025

Description

Screenshots (if appropriate):

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

github-actions Bot commented Nov 5, 2025

Uh oh!

alex-w commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alex-w commented Nov 5, 2025

Uh oh!

alex-w left a comment

Choose a reason for hiding this comment

Uh oh!

henrysky commented Nov 5, 2025

Uh oh!

10110111 Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

henrysky Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

10110111 commented Nov 6, 2025

Uh oh!

alex-w commented Nov 6, 2025

Uh oh!

alex-w commented Nov 6, 2025

Uh oh!

github-actions Bot commented Nov 6, 2025

Uh oh!

alex-w commented Nov 8, 2025

Uh oh!

10110111 commented Nov 8, 2025

Uh oh!

alex-w commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

10110111 commented Nov 8, 2025

Uh oh!

alex-w commented Nov 8, 2025

Uh oh!

10110111 commented Nov 8, 2025

Uh oh!

alex-w commented Nov 8, 2025

Uh oh!

henrysky commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

10110111 commented Nov 8, 2025

Uh oh!

henrysky commented Nov 9, 2025

Uh oh!

alex-w Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

henrysky Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

alex-w commented Nov 10, 2025

Uh oh!

alex-w commented Nov 11, 2025

Uh oh!

Uh oh!

github-actions Bot commented Nov 19, 2025

Uh oh!

github-actions Bot commented Dec 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alex-w commented Nov 5, 2025 •

edited

Loading

alex-w commented Nov 8, 2025 •

edited

Loading

henrysky commented Nov 8, 2025 •

edited

Loading