Keep N most recent directories - #2
Merged
Merged
Conversation
2 tasks
Member
|
This might require a major version bump, since it worked completely different. Just making it 1.0 would be good. |
Member
|
@niallo what do you think of moving this repo to the Strider org? |
Member
|
Ping 👍 |
Member
|
@niallo ding ding ding 🔔 😸 |
Member
|
Hallo, anyone home 😉 |
Member
|
@knownasilya done - moved! sorry for the delay |
Member
|
Woot! My persistence paid off |
Member
|
Now I just need npm rights |
Member
|
@knownasilya added on npm too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dirkeeper currently deletes the oldest
countsubdirectories, rather than what the README documents, which is deleting everything but the most recentcountsubdirectories. The special-cased counts of 0 (to delete everything) and greater-than-the-number-of-subdirectories (to delete nothing) work correctly, but are inconsistent with the less-than-the-number-of-subdirectories case.I've changed the relevant test to make the difference more obvious by keeping a
countthat's different than the number of directories that should be deleted, then changed thedirsarray slice to delete all-but-the-newest-n so it passes.