Engine sync: sfx field + matrix cases, loudness AAC headroom, v5 cut ruleset#30
Merged
Conversation
…leset
- Segments gain sfx:[{file,start,gain?}] — timed sound accents mixed like
bleep tones (source-time, speed-projected, truncated at the boundary).
- validate: sfx file/window checks + a warnings channel (gain>1).
- test-matrix: sfx / sfx+speed / sfx+bleep cases.
- loudness: de-clip targets ceiling−0.15 dB (AAC overshoot headroom).
- SKILL: comedy air, device escalation, sound accent economy, stakes ticker,
reaction grammar woven into the ruleset.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
StuMason
marked this pull request as ready for review
July 2, 2026 21:17
…stutter Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
StuMason
added a commit
that referenced
this pull request
Jul 7, 2026
* De-Stu the docs: generic recording paths + a sixty-second quickstart obs-setup.md pointed three times at ~/Code/tools/edator/recordings, which only exists on one machine in the world. Any folder works; say so. README gains a quickstart for the person who already has an mp4 and no OBS/roll setup: transcribe, hand-write the smallest valid pack, validate, render. The example pack is semantically validated against validate.js. Also documents the optional Python/OpenCV requirement for face-tracked features, which previously only lived in the studio's doctor script. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Fix CI: read fd 0 for stdin packs, regenerate motion goldens Two unrelated breakages that have kept main red since #28: 1. loadPack re-opened /dev/stdin by path, which now fails with ENXIO when the pipe's write end has already closed (spawnSync with input: on current runners). Read fd 0 directly for '-' or '/dev/stdin'. 2. The engine syncs (#28-#30) improved the motionBlur/push graph - real fps oversampling before zoompan instead of zoompan frame duplication (tmix over duplicated frames produced no blur), and dropped a redundant double fps=30 - but the golden snapshots were never regenerated. Regenerated with GOLDEN=1; only look-blur and moves drift, exactly matching the shipped engine behaviour. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * CI: install ffmpeg for the render matrix test test-matrix.mjs (added in the #29/#30 engine syncs) renders real synthetic footage; the dry-run-only suite stays dependency-free. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync from the studio's v5 work (studio PR StuMason/edator-studio#2).
sfxsegment field: timed sound accents — source-time{file, start, gain?}, mixed UNDER speech exactly like bleep tones, projected underspeed, truncated at the segment boundary. One ffmpeg input per occurrence.gain > 1warns).🤖 Generated with Claude Code